[brockit] Adding drop! command for B🚀#37057
Merged
Merged
Conversation
Contributor
📋 Code Owners Summary4 file(s) changed, 4 with assigned owners 1 team(s) affected: Owners and Their Files
|
emerick
approved these changes
Jun 6, 2026
This command is a sibling to `reassign!`, in the sense that it also creates a commit with a subcommand tag to guide a rebase event. In this case though, the `drop!` indicates that a target commit is supposed to be dropped during rebase. Similar to `ressign!` handling, this type of pin can only be processed with `--squash-minor-bumps`, and the target commit cannot be another pinned commit. This change is being implemented for rebase v2 only. Bug: brave/brave-browser#56150
cdesouza-chromium
force-pushed
the
brockit+drop-command
branch
from
13e8509 to
0b35bfe
Compare
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command is a sibling to
reassign!, in the sense that it alsocreates a commit with a subcommand tag to guide a rebase event. In this
case though, the
drop!indicates that a target commit is supposed tobe dropped during rebase.
Similar to
ressign!handling, this type of pin can only be processedwith
--squash-minor-bumps, and the target commit cannot be anotherpinned commit.
This change is being implemented for rebase v2 only.
Bug: brave/brave-browser#56150