[ai-chat][msam] AIChatService binding to string_view UaF#37062
Open
cdesouza-chromium wants to merge 1 commit into
Open
[ai-chat][msam] AIChatService binding to string_view UaF#37062cdesouza-chromium wants to merge 1 commit into
AIChatService binding to string_view UaF#37062cdesouza-chromium wants to merge 1 commit into
Conversation
cdesouza-chromium
force-pushed
the
msam+fix-ai-chat-service-uaf
branch
from
0b2af94 to
3cceb87
Compare
This is something we need to reach out to the Chromium team about, as IMO `BoundOnce` should not just allow this type of binding without some sort of explicit annotation. Resolves brave/internal#1763 Resolves brave/internal#1765 Resolves brave/internal#1764 Resolves brave/internal#1766
cdesouza-chromium
force-pushed
the
msam+fix-ai-chat-service-uaf
branch
from
3cceb87 to
cfd0360
Compare
netzenbot
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something we need to reach out to the Chromium team about, as
IMO
BoundOnceshould not just allow this type of binding without somesort of explicit annotation.
Resolves https://github.com/brave/internal/issues/1763
Resolves https://github.com/brave/internal/issues/1765
Resolves https://github.com/brave/internal/issues/1764
Resolves https://github.com/brave/internal/issues/1766