WASM: Update boltz client dependency and use included wasm tokio-tungstenite #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
daniel-wasm-boltz-rust-client
branch
from
1948bf4 to
4391a69
Compare
dangeross
reviewed
Mar 12, 2025
danielgranhao
force-pushed
the
daniel-wasm-boltz-rust-client
branch
from
a237ae1 to
f75d2d4
Compare
|
Interestingly enough, the changes here fix #746. I feel a bit uneasy because I don't fully understand why. My best guess is that somehow, the lower latency to a local websocket server was causing some concurrency issue between sending and receiving? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the boltz client dependency to the updated version proposed in SatoshiPortal/boltz-rust#91.
Besides updating the dependency, it also starts using it for connecting the status stream websocket. The updated boltz client uses
tokio-tungstenite-wasmfor websockets, which doesn't expose pinging. To address this Boltz now supports application-level ping messages, which the boltz client PR also exposes.Because now the boltz client is used to start the websocket connection, I've merged the
BoltzStatusStreamstruct intoBoltzSwapper, which now also implementsSwapperStatusStream.The electrum client is still kept in use. Supporting WASM will require using esplora, which I propose we address in a follow-up PR.