Skip to content

refactor: use for...of for better readability #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor: use for...of for better readability #3472

wants to merge 1 commit into from

Conversation

noritaka1166
Copy link
Contributor

use for...of for better readability

@brianc
Copy link
Owner

brianc commented Jun 5, 2025

I appreciate the thought here but I'm going to stick with for i loops in the code where they exist. Last I checked they still have a performance improvement/advantage over a for of loop. While none of these code paths are seriously white-hot execution frequency I still don't mind using for i loops and so I'm just going to pass on this one. Thank you though!

@brianc brianc closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noritaka1166 @brianc