use Array.isArray() function to check for arrays#844
Open
sebasbaumh wants to merge 1 commit intobrody2consult:devfrom
Open
use Array.isArray() function to check for arrays#844sebasbaumh wants to merge 1 commit intobrody2consult:devfrom
sebasbaumh wants to merge 1 commit intobrody2consult:devfrom
Conversation
this ensures correct array detection also for iframes (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray)
Owner
|
Thanks for the contribution. I hope to give my response in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the plugin is checking for arrays by comparing the constructor to the
Arrayclass.There are cases where a JavaScript function running in another iframe or window is calling a Cordova-sqlite-storage function (like GWT compiled JavaScript code).
In that case there are different array prototypes (one per window object), which nevertheless are functionally identical.
But as the check returns false, the given array is not processed any further.
The function to be used to detect an array even in these cases is
Array.isArray().It ensures correct array detection also for iframes.
See also http://web.mit.edu/jwalden/www/isArray.html :