Skip to content

Now get's list of models from ollama instead of hardcoding them. also Improve Browser navigation and error handling #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iplayfast
Copy link

Fix for issue #330
Dynamically loads models from Ollama.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

- Add isolation of navigation actions to ensure page loads completely before further actions
- Add browser context validation to catch initialization errors early
- Add state validation to ensure browser state is available before proceeding

The navigation isolation particularly helps with Ollama models where sequential
actions might be attempted before page load completes. Browser context and state
validation provides earlier, clearer error messages for common failure cases.
@iplayfast
Copy link
Author

Mainly for making Ollama more reliable but probably others as well.

@iplayfast iplayfast changed the title Now get's list of models from ollama instead of hardcoding them. Now get's list of models from ollama instead of hardcoding them. also Improve Browser navigation and error handling Feb 24, 2025
Modified the llm_num_ctl to be more approriate for various models
Updated llm so models are consolidated
fixed some errors in utils.py
@iplayfast
Copy link
Author

This is much more stable

At this point using ollama I am able to run the default agent task (opening openai and clicking the first link). It's also fairly fast.

I've not tested if any of these changes have affected the other models so that needs to be tested, but I'm hopeful that they will work as before or better.

@warmshao
Copy link
Collaborator

hi, Please don't change so much content in one pull request. It's very difficult for me to review and verify. Also, please don't change content that doesn't need to be modified for now.

@iplayfast
Copy link
Author

You should be able to do three separate pull requests. (I don't know why they were all concatenated).

@DaWe35
Copy link

DaWe35 commented Mar 20, 2025

@iplayfast great pr, but you only opened one PR.
If you push 3 commits to a branch, then the PR will contain all changes, because you open PRs from a branch to another. (Git basics) ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants