Add new line after seeds.rb when appending#3
Open
RoopeHakulinen wants to merge 1 commit intobrowsermedia:masterfrom
RoopeHakulinen:master
Open
Add new line after seeds.rb when appending#3RoopeHakulinen wants to merge 1 commit intobrowsermedia:masterfrom RoopeHakulinen:master
RoopeHakulinen wants to merge 1 commit intobrowsermedia:masterfrom
RoopeHakulinen:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran to a problem while adding bcms_news after bcms_event to my BrowserCMS-project. The seeds.rb appendings go to same line and that gives an error while trying to run rake db:install. There is no issue if you don't add any other modules that append this file after bcms_event.
Unlike other modules, bcms_event didn't seem to add new line (\n) after
so I added it there. Other modules I am referring to are
bcms_news (https://github.com/browsermedia/bcms_news/blob/master/lib/generators/bcms_news/install/install_generator.rb)
and bcms_feeds (https://github.com/browsermedia/bcms_feeds/blob/master/lib/generators/bcms_bmedia_feeds/install/install_generator.rb).
This is my first pull request ever, so if there is something I could have done different or better, please let me know.