Update Node dependency to newer version#4
Merged
brucala merged 1 commit intobrucala:mainfrom Jul 10, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 62.20% 62.20%
=======================================
Files 8 8
Lines 545 545
=======================================
Hits 339 339
Misses 206 206
☔ View full report in Codecov by Sentry. |
brucala
approved these changes
Jul 10, 2023
Owner
brucala
left a comment
There was a problem hiding this comment.
Awesome, thanks for looking into this!
I'll register a new version tonight, together with a couple other minor updates I have in mind.
Closed
Owner
|
@George9000 On a related note, I just open #5 to possibly remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the npm version issue and updates the Project.toml and src/Deneb.jl to use the NodeJS_18 binary builder recipe in Yggdrasil. See this issue.
I have tested the changes locally in the dev directory housing Deneb. All tests passed; see below in expandable section. The dev package was also used in another project. Only one issue was identified: the user may need to
rm -rf ~/.npminstalled by the earlier version (NodeJS_16_jll). Otherwise, the user may receive an error:Error: CanvasRenderer is missing a valid canvas or context. See stack overflow post.test summary