Skip to content

Update Node dependency to newer version#4

Merged
brucala merged 1 commit intobrucala:mainfrom
George9000:main
Jul 10, 2023
Merged

Update Node dependency to newer version#4
brucala merged 1 commit intobrucala:mainfrom
George9000:main

Conversation

@George9000
Copy link
Copy Markdown
Contributor

This addresses the npm version issue and updates the Project.toml and src/Deneb.jl to use the NodeJS_18 binary builder recipe in Yggdrasil. See this issue.

I have tested the changes locally in the dev directory housing Deneb. All tests passed; see below in expandable section. The dev package was also used in another project. Only one issue was identified: the user may need to rm -rf ~/.npm installed by the earlier version (NodeJS_16_jll). Otherwise, the user may receive an error: Error: CanvasRenderer is missing a valid canvas or context. See stack overflow post.

test summary
julia> versioninfo()
Julia Version 1.9.2
Commit e4ee485e90 (2023-07-05 09:39 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin21.6.0)
  CPU: 10 × Apple M1 Max
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, apple-m1)
  Threads: 5 on 8 virtual cores
Environment:
  JULIA_NUM_THREADS = 4
  JULIA_EDITOR = Emacs
  JULIA_PKG_DEVDIR = /Users/foo/Documents/julia/dev
  JULIA_USE_NEW_PARSER = 0

(Deneb) pkg> test
    Updating registry at `~/.julia/registries/General.toml`
    Updating `~/Documents/julia/dev/Deneb.jl/Project.toml`
  [682c06a0] + JSON v0.21.4
  [1e8d2bf6] + MultilineStrings v0.1.1
  [bd369af6] + Tables v1.10.1
  [c1e1d063] + NodeJS_18_jll v18.16.0+0
    Updating `~/Documents/julia/dev/Deneb.jl/Manifest.toml`
  [9a962f9c] + DataAPI v1.15.0
  [e2d170a0] + DataValueInterfaces v1.0.0
  [82899510] + IteratorInterfaceExtensions v1.0.0
  [692b3bcd] + JLLWrappers v1.4.1
  [682c06a0] + JSON v0.21.4
  [1e8d2bf6] + MultilineStrings v0.1.1
  [bac558e1] + OrderedCollections v1.6.0
  [69de0a69] + Parsers v2.7.1
  [aea7be01] + PrecompileTools v1.1.2
  [21216c6a] + Preferences v1.4.0
  [3783bdb8] + TableTraits v1.0.1
  [bd369af6] + Tables v1.10.1
  [c1e1d063] + NodeJS_18_jll v18.16.0+0
  [56f22d72] + Artifacts
  [2a0f44e3] + Base64
  [ade2ca70] + Dates
  [b77e0a4c] + InteractiveUtils
  [8f399da3] + Libdl
  [37e2e46d] + LinearAlgebra
  [56ddb016] + Logging
  [d6f4376e] + Markdown
  [a63ad114] + Mmap
  [de0858da] + Printf
  [9a3f8284] + Random
  [ea8e919c] + SHA v0.7.0
  [9e88b42a] + Serialization
  [fa267f1f] + TOML v1.0.3
  [8dfed614] + Test
  [cf7118a7] + UUIDs
  [4ec0a83e] + Unicode
  [e66e0078] + CompilerSupportLibraries_jll v1.0.5+0
  [4536629a] + OpenBLAS_jll v0.3.21+4
  [8e850b90] + libblastrampoline_jll v5.8.0+0
     Testing Deneb
      Status `/private/var/folders/mh/d010xh0j5ss8yws8rknh568c0000gn/T/jl_KsOwBg/Project.toml`
  [b5a61f88] Deneb v0.1.0 `~/Documents/julia/dev/Deneb.jl`
  [8dfed614] Test `@stdlib/Test`
      Status `/private/var/folders/mh/d010xh0j5ss8yws8rknh568c0000gn/T/jl_KsOwBg/Manifest.toml`
  [9a962f9c] DataAPI v1.15.0
  [e2d170a0] DataValueInterfaces v1.0.0
  [b5a61f88] Deneb v0.1.0 `~/Documents/julia/dev/Deneb.jl`
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.4.1
  [682c06a0] JSON v0.21.4
  [1e8d2bf6] MultilineStrings v0.1.1
  [bac558e1] OrderedCollections v1.6.0
  [69de0a69] Parsers v2.7.1
  [aea7be01] PrecompileTools v1.1.2
  [21216c6a] Preferences v1.4.0
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.10.1
  [c1e1d063] NodeJS_18_jll v18.16.0+0
  [56f22d72] Artifacts `@stdlib/Artifacts`
  [2a0f44e3] Base64 `@stdlib/Base64`
  [ade2ca70] Dates `@stdlib/Dates`
  [b77e0a4c] InteractiveUtils `@stdlib/InteractiveUtils`
  [8f399da3] Libdl `@stdlib/Libdl`
  [37e2e46d] LinearAlgebra `@stdlib/LinearAlgebra`
  [56ddb016] Logging `@stdlib/Logging`
  [d6f4376e] Markdown `@stdlib/Markdown`
  [a63ad114] Mmap `@stdlib/Mmap`
  [de0858da] Printf `@stdlib/Printf`
  [9a3f8284] Random `@stdlib/Random`
  [ea8e919c] SHA v0.7.0 `@stdlib/SHA`
  [9e88b42a] Serialization `@stdlib/Serialization`
  [fa267f1f] TOML v1.0.3 `@stdlib/TOML`
  [8dfed614] Test `@stdlib/Test`
  [cf7118a7] UUIDs `@stdlib/UUIDs`
  [4ec0a83e] Unicode `@stdlib/Unicode`
  [e66e0078] CompilerSupportLibraries_jll v1.0.5+0 `@stdlib/CompilerSupportLibraries_jll`
  [4536629a] OpenBLAS_jll v0.3.21+4 `@stdlib/OpenBLAS_jll`
  [8e850b90] libblastrampoline_jll v5.8.0+0 `@stdlib/libblastrampoline_jll`
Precompiling project...
  15 dependencies successfully precompiled in 15 seconds
     Testing Running tests...
Test Summary:  | Pass  Total   Time
Deneb.jl tests |  269    269  14.1s
     Testing Deneb tests passed

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4b438d3) 62.20% compared to head (65fe4a4) 62.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   62.20%   62.20%           
=======================================
  Files           8        8           
  Lines         545      545           
=======================================
  Hits          339      339           
  Misses        206      206           
Impacted Files Coverage Δ
src/Deneb.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Owner

@brucala brucala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for looking into this!

I'll register a new version tonight, together with a couple other minor updates I have in mind.

@brucala brucala merged commit 7b8cdb9 into brucala:main Jul 10, 2023
@brucala brucala mentioned this pull request Jul 10, 2023
@brucala
Copy link
Copy Markdown
Owner

brucala commented Jul 10, 2023

@George9000 On a related note, I just open #5 to possibly remove the NodeJS dependency.
I believe we would only need to build a recipe for vl-convert in Yggdrasil. I'm not very familiar with building recipes in Yggdrasil, but I'll give it a try when i find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants