sources: bound []map API batches by MaxBatchBytes (drop-in, 1/3) - #1095
Open
iremcaginyurtturk wants to merge 1 commit into
Open
sources: bound []map API batches by MaxBatchBytes (drop-in, 1/3)#1095iremcaginyurtturk wants to merge 1 commit into
iremcaginyurtturk wants to merge 1 commit into
Conversation
Add a byte-based flush to 23 []map API sources whose read loops already accumulated rows and flushed by count. The MaxBatchBytes check is a drop-in: with the cap off the emitted batches are byte-identical to before; with it on, the accumulated batch is flushed before appending a row that would push it past the cap. Also flush-and-stop exactly at --limit in blobstore and stripe.
Contributor
|
Reviews (1): Last reviewed commit: "sources: bound []map API batches by MaxB..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a byte-based batch cap (
MaxBatchBytes, from--batch-size, default 512 MiB) to 23[]mapAPI sources whose read loops already flushed by row count. Drop-in: with the cap off, batches are byte-identical to before; with it on, the batch is flushed before a row would exceed the cap. Also flush-and-stop exactly at--limitin blobstore and stripe.Prevents wide-row sources from accumulating an unbounded in-memory Arrow batch. Grouping is invisible downstream (rows keep order; destination concatenates batches).
1 of 3 independent PRs (drop-in / per-page+fast-path / whole-set), each off
main.