fix: MRO Issue in operator/clickhouse_dbapi #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a method resolution order (MRO) issue in the ClickHouse.*Operator implementations.
For example
ClickHouseBranchSQLOperator, due to the current inheritance order, parameters intended for the sql.BranchSQLOperator (such as follow_task_ids_if_true, follow_task_ids_if_false, and parameters) are not being correctly processed. This results in an “Invalid arguments” error when the operator is instantiated.Background
The operator is defined as follows:
Because of Python’s MRO, the init method from ClickHouseBaseDbApiOperator (or its parent, BaseSQLOperator) is encountered before sql.BranchSQLOperator.init. As a result, any branch-specific parameters are not recognized, leading to failures when those parameters are passed during instantiation.