fix(beef): set BUMP index when merging rawtx to BEEF#322
Merged
mrz1836 merged 1 commit intoMay 28, 2026
Merged
Conversation
|
dzolt-4chain
approved these changes
May 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Beef.MergeRawTx(transaction/beef.go) setsbeefTx.Transaction.MerklePathandbeefTx.DataFormat = RawTxAndBumpIndexwhen abumpIndexis provided, but never assignsbeefTx.BumpIndex = *bumpIndex. The siblingMergeTransactionWithTxiddoes this correctly. The wire-format serializer encodestx.BumpIndexdirectly, so the bug only surfaces after serialization.Testing Procedure
Describe the tests you've added or any testing steps you've taken.
go test ./...Checklist:
CHANGELOG.mdwith my changesgolangci-lint rungo fmtandgo vetone final time before requesting a review