Merged
Conversation
Closed
8 tasks
maark1106
approved these changes
May 17, 2025
mangsuyo
reviewed
May 17, 2025
Member
mangsuyo
left a comment
mangsuyo
left a comment
There was a problem hiding this comment.
고생하셨습니다!
또한, 엑셀 가변 데이터를 어떻게 Coupon DB에 저장하실지 계획을 여쭤봐도 될까요?
| MISSION_CERTIFICATION_REWARD("mission_certification_reward", 100, PointChangeType.MISSION), | ||
| MISSION_VISIT_REWARD("mission_visit_reward", 10, PointChangeType.MISSION), | ||
| FESTIVAL_REWARD("festival_reward", 50, PointChangeType.EARN), | ||
| COUPON_EVENT_REWARD("event_reward", 100, PointChangeType.EARN), |
Member
There was a problem hiding this comment.
P1: 다른 포인트 타입 네이밍으로 해야할 것 같네요!
Contributor
Author
There was a problem hiding this comment.
확인 후 수정하였습니다. 세세한 검토 감사드립니다!
| import java.util.Optional; | ||
|
|
||
| public interface CouponRepository extends JpaRepository<Coupon, Long> { | ||
| Optional<Coupon> findByCode(String code); |
Contributor
Author
마이그레이션 스크립트에 작성하려고 하였으나 쿠폰의 코드가 노출 될 수 있어. 직접 스크립트를 실행하려고 합니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
버디야 부스 쿠폰 등록 이벤트 구현[#355]
🛠️ 작업 내용
Coupon엔티티 생성Coupon코드 입력 시 쿠폰의 유효성과 사용 여부를 검사🎯 리뷰 포인트
📎 커밋 범위 링크