Skip to content

Stop using deprecated Cucumber step #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

Stop using deprecated Cucumber step #376

merged 3 commits into from
May 6, 2025

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented May 2, 2025

Goal

Stop using deprecated Cucumber step.

Design

The step used instead is functionally equivalent - expecting at least the number of spans given. The replace step will be removed in the next major version of Maze Runner.

Testing

Covered by CI.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented May 2, 2025

Android notifier sizes

Format Size of apk (kB)
APK 614.95
APK with Bugsnag 714.93

Android notifier size impact

Format Size impact of Bugsnag (kB)
APK 99.98
Minified APK 47.28

Generated by 🚫 Danger

@twometresteve twometresteve requested a review from tomlongridge May 6, 2025 14:06
@twometresteve twometresteve merged commit 1aff736 into next May 6, 2025
18 checks passed
@twometresteve twometresteve deleted the tms/step-use branch May 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants