End to end tests #594
Merged
End to end tests #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-13898/end-to-end-tests
branch
from
ee8a2a9 to
c2d19b1
Compare
gingerbenw
force-pushed
the
PLAT-13898/end-to-end-tests
branch
from
c2d19b1 to
ce6a459
Compare
Browser bundle sizeNPM build
CDN build
Code coverage
Total:
Generated against 9c00af7 on 20 March 2025 at 15:43:07 UTC |
gingerbenw
reviewed
Mar 19, 2025
| @@ -30,7 +30,7 @@ class InstrumentedComponent extends React.Component<InstrumentedComponentProps> | |||
| } | |||
|
|
|||
| async componentDidMount () { | |||
| if (this.componentMountSpan && BugsnagPerformance.appState === 'ready') { | |||
There was a problem hiding this comment.
@AnastasiiaSvietlova this logic was the wrong way around - the fact we hadn't detected this probably means the unit tests aren't sufficient
gingerbenw
force-pushed
the
PLAT-13898/end-to-end-tests
branch
from
a8c2190 to
0e9e323
Compare
lemnik
approved these changes
Mar 20, 2025
yousif-bugsnag
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add end to end tests for component lifecycle spans in react
Changeset
This PR also resolves a bug in component span instrumentation where component spans were not ended if the app state was not 'ready'
Testing
Added new end to end tests in React