-
Notifications
You must be signed in to change notification settings - Fork 257
Add error boundary e2e tests in React Native #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
7803fc9
to
f25be8b
Compare
@@ -0,0 +1,11 @@ | |||
@react_error_boundary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used / required? I don't see @react_error_boundary
defined anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. Deleted.
...native/features/fixtures/scenario-launcher/src/scenarios/ReactNativeErrorBoundaryScenario.js
Show resolved
Hide resolved
@react_error_boundary | ||
Feature: React Error Boundary support | ||
|
||
Scenario: basic error boundary usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario: basic error boundary usage | |
Scenario: ErrorBoundary component reports errors |
@@ -0,0 +1,11 @@ | |||
@react_error_boundary | |||
Feature: React Error Boundary support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature: React Error Boundary support | |
Feature: ReactNative ErrorBoundary support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Goal
This PR adds e2e tests for ErrorBoundary in React Native.
Changeset
Add
ReactNativeErrorBoundaryScenario
andreact-native-error-boundary.feature
.