Skip to content

refactor: register the pre-built protoc toolchain #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stagnation wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: register the pre-built protoc toolchain #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ bazel_dep(name = "googletest", version = "1.15.2")
bazel_dep(name = "jsonnet_go", version = "0.20.0")
bazel_dep(name = "opentelemetry-proto", version = "1.5.0")
bazel_dep(name = "platforms", version = "0.0.11")
bazel_dep(name = "toolchains_protoc", version = "0.4.2") # must come BEFORE protobuf so the toolchain registration wins
bazel_dep(name = "protobuf", version = "29.3")
bazel_dep(name = "remote_config_cc")
bazel_dep(name = "remote_config_sh")
Expand All @@ -29,7 +30,11 @@ bazel_dep(name = "rules_shell", version = "0.3.0")
# but held back to be compatible with bb-remote-execution.
bazel_dep(name = "rules_proto", version = "7.1.0")
bazel_dep(name = "toolchains_llvm", version = "1.3.0")
bazel_dep(name = "toolchains_protoc", version = "0.3.4")

# Mirror the protoc setup from bb-storage: https://github.com/buildbarn/bb-storage/pull/248
# NB: Match protobuf above, until it ships a pre-built binary toolchain itself
protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")
protoc.toolchain(version = "v29.3")

# # Workarounds 2024-06-27
# ERROR: in tag at https://bcr.bazel.build/modules/grpc-java/1.62.2/MODULE.bazel:89:15: no repository visible as '@com_google_protobuf_javalite' to the repository '@@grpc-java~', but referenced by label '@com_google_protobuf_javalite//:protobuf_javalite' in attribute 'target' of tag 'override'. Is the module 'grpc-java' missing a bazel_dep or use_repo(..., "com_google_protobuf_javalite")?
Expand Down
4 changes: 2 additions & 2 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.