New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK Refactor #117

Merged

andrederoos merged 21 commits into develop from python-sdk-refactor

Dec 30, 2019

Contributor

angelomelonas commented Sep 13, 2019

No description provided.

angelomelonas added 7 commits

September 12, 2019 17:19


          Part of big Python SDK refactor. Work in Progress.

01e97e7


          Refactored the http directory to match that of the other SDKs.

e049134


          Updated the python SDK exceptions to match that of the other SDKs.

5bc3d5d


          Updated the python SDK core models to match that of the other SDKs. A…

c4c4842

…lso fixed some of the Tinker related imports.


          Fixed broken tests by using local imports and resolving circular impo…

…rts.


          Small test refactors as well as a directory typo fix.

4e1e0da


          Added a TODO for the PSD2 context test.

9131d9e

angelomelonas added enhancement pending review by andré pending review labels

angelomelonas requested review from FNG21 and andrederoos

September 13, 2019 16:31

angelomelonas self-assigned this


          Refactored the json/adapters.

2fb8645

andrederoos requested a review from jesperromers

September 19, 2019 17:39

jesperromers reviewed

View reviewed changes

bunq/sdk/context/api_context.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/context/api_context.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/http/api_client.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/http/api_client.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/http/api_client.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/anchored_object_model_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/anchored_object_model_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/anchored_object_model_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/geolocation_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/geolocation_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/installation_adapter.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/installation_context_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/installation_context_adapter.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/monetary_account_reference_adapter.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/json/pagination_adapter.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/model/core/session_server.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/model/core/session_token.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/model/core/uuid.py Outdated Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

bunq/sdk/model/generated/endpoint.py Show resolved Hide resolved

jesperromers reviewed

View reviewed changes

tests/context/test_user_context.py Outdated Show resolved Hide resolved

jesperromers commented Sep 20, 2019

@angelomelonas please have a look at my remarks, the reorganization of classes seems fine, but there's still a lot that can be improved. the things I would consider easy wins have been marked.

angelomelonas added 12 commits

September 23, 2019 14:50


          feature/python-sdk-refactor Merge Request fixes and code cleanup.

626b832


          feature/python-sdk-refactor Removed ABC parameters.

2064d20


          feature/python-sdk-refactor Generated better docstrings and type anno…

2ed259e

…tations for bunq_context.


          feature/python-sdk-refactor Updated bunq_context according to new MR …

186f64c

…comments. Other classes to follow.


          feature/python-sdk-refactor Updated Type Annotations for all the Cont…

7279a09

…ext classes.


          feature/python-sdk-refactor Updated Type Annotations for all the Exce…

78b3a82

…ption classes.


          feature/python-sdk-refactor Updated Type Annotations for all the Http…

56ca196

… classes.


          feature/python-sdk-refactor Updated Type Annotations for all the Http…

b73076f

… classes (missed api_client).


          feature/python-sdk-refactor Removed unnecessary python 2 object inher…

712e963

…itance.


          feature/python-sdk-refactor Updated Type Annotations for all the JSON…

2d305d0

… classes.


          feature/python-sdk-refactor Updated Type Annotations for all the mode…

250335c

…l/core classes.


          feature/python-sdk-refactor General updates, removing unnecessary doc…

56b196e

…strings, fixing incorrect type annotations, reformatting code for better readability, etc.

angelomelonas commented

View reviewed changes

bunq/sdk/context/bunq_context.py Outdated Show resolved Hide resolved

wilmardo commented Oct 18, 2019

Just tested this to see if it resolves #116 but the issue still seems there :)

DoronV reviewed

View reviewed changes

bunq/sdk/exception/EXCEPTIONS.md Outdated Show resolved Hide resolved


          feature/python-sdk-refactor Code review fix.

20e7abc

basnijholt commented Nov 27, 2019

Is this ready to merge? It seems like there is no activity here.

I would like to make some contributions, however, considering this PR touches a lot of code, I want to avoid merge conflicts and will wait until this is merged.

andrederoos approved these changes

View reviewed changes

andrederoos merged commit e06520c into develop

angelomelonas deleted the python-sdk-refactor branch

February 20, 2020 14:46

angelomelonas mentioned this pull request

Add type hint. #89

Closed

This was referenced Aug 8, 2020

Is this repository even maintained? #140

Closed

cannot import name 'ApiContext' from 'bunq.sdk.context' #132

Closed

angelomelonas mentioned this pull request

Breaking changes since v1.13.0 #142

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement pending review by andré pending review