fix: duplicated function names for same interfaces and export #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderVanRiessen
requested review from
tschneidereit and
vados-cosmonic
as code owners
This was referenced Oct 13, 2025
There was a problem hiding this comment.
Hey @SanderVanRiessen thanks for this addition -- it looks good to me, but I'd love some tests here to back the new functionality, and regression-proof the old functionality if you don't mind!
|
BTW, please ignore the windows CI failures -- we're unfortunately having problems with the windows jobs in CI right now. |
vados-cosmonic
force-pushed
the
fix/duplicated-function-names-for-same-interfaces-and-export
branch
from
c71e88e to
806e832
Compare
|
CI failures from the windows runs should be good to go now! |
vados-cosmonic
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
LGTM 🚀
Thanks for going above and beyond on this @SanderVanRiessen !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the following issue: #307