-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instantiation linking] create and import WASMMemoryInstance for aot #3887
Open
lum1n0us
wants to merge
10
commits into
bytecodealliance:dev/instantiate_linking
Choose a base branch
from
lum1n0us:feat_inst_linking_memory_aot
base: dev/instantiate_linking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[instantiation linking] create and import WASMMemoryInstance for aot #3887
lum1n0us
wants to merge
10
commits into
bytecodealliance:dev/instantiate_linking
from
lum1n0us:feat_inst_linking_memory_aot
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
5 times, most recently
from
November 1, 2024 13:00
9ef6ec2
to
730cd55
Compare
lum1n0us
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
November 1, 2024 13:35
This was referenced Nov 3, 2024
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
from
November 4, 2024 06:42
730cd55
to
15f9ad5
Compare
- ~99% same with memory_instantiation() in wasm_runtime.c - new apis to create and destroy memory
…tantiation logic in wasm_runtime.c
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
from
November 4, 2024 07:41
15f9ad5
to
878287d
Compare
lum1n0us
commented
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #3845