Skip to content

Prevent local cells from overflow #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent local cells from overflow #4211

wants to merge 1 commit into from

Conversation

lum1n0us
Copy link
Collaborator

No description provided.

@lum1n0us lum1n0us requested a review from Copilot April 24, 2025 08:01
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to prevent local cell overflow by adding an overflow check to the preserve_referenced_local function.

  • Added an overflow check for preserved_offset against loader_ctx->max_dynamic_offset in wasm_loader.c.

@lum1n0us lum1n0us force-pushed the fix/prevent_too_much_local_cells branch 2 times, most recently from 06894d3 to 74aa7b3 Compare April 24, 2025 08:36
TianlongLiang
TianlongLiang approved these changes Apr 27, 2025
View reviewed changes
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

@lum1n0us lum1n0us force-pushed the fix/prevent_too_much_local_cells branch from 74aa7b3 to 3cf5d5f Compare April 27, 2025 12:55
@lum1n0us lum1n0us force-pushed the fix/prevent_too_much_local_cells branch from 3cf5d5f to 94ecbaa Compare May 5, 2025 02:50
xujuntwt95329
xujuntwt95329 approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wenyongh
wenyongh approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt left review comments

Copilot code review Copilot Copilot left review comments

@xujuntwt95329 xujuntwt95329 xujuntwt95329 approved these changes

@wenyongh wenyongh wenyongh approved these changes

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lum1n0us @yamt @xujuntwt95329 @wenyongh @TianlongLiang