Skip to content

Draft: Symmetric ABI tracking and minor side functionality #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 868 commits into
base: main
Choose a base branch
from
Draft

Draft: Symmetric ABI tracking and minor side functionality #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
868 commits
Select commit Hold shift + click to select a range
4e7d6fb
link to newest wasm-tools
cpetig Mar 30, 2025
81a667d
post-merge cleanup
cpetig Mar 30, 2025
dd48a91
skeletal future support
cpetig Apr 9, 2025
68f85e0
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Apr 10, 2025
a805d3c
update wasm-tools
cpetig Apr 10, 2025
5d17797
fix compilation after merge
cpetig Apr 10, 2025
e200698
add from handle method (similar to stream) needed for lifting
cpetig Apr 12, 2025
8b09645
cargo fmt
cpetig Apr 12, 2025
138bea4
reintroduce pointers in symmetric
cpetig Apr 12, 2025
d9ac71d
move common parts outside of async example
cpetig Apr 12, 2025
c82ff28
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Apr 13, 2025
bcbc000
future support compiles (reading is work in progress)
cpetig Apr 13, 2025
e2e7ac4
potentially complete implementation
cpetig Apr 13, 2025
d369397
no longer blocking on write
cpetig Apr 13, 2025
47377f4
future+stream c++ generation, fix code
cpetig Apr 14, 2025
992a0dc
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Apr 14, 2025
82f4fb5
move the variable
cpetig Apr 14, 2025
7116089
include future on demand
cpetig Apr 14, 2025
56397ce
stream example skeleton
cpetig Apr 14, 2025
f5ae2a6
ongoing work on stream support
cpetig Apr 15, 2025
b18f94d
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Apr 16, 2025
30ebfc3
stream write implementation
cpetig Apr 16, 2025
9688b23
generate deleted resource copy operators to simplify compiler errors
cpetig Apr 17, 2025
bd20db3
fix stream logic, output EOF message
cpetig Apr 17, 2025
e42ef68
fix eof handling and requeue reading
cpetig Apr 17, 2025
ac69149
Merge remote-tracking branch 'origin/main' into work-in-progress
cpetig Apr 17, 2025
fd7a07b
report the change_event descriptor
cpetig Apr 17, 2025
909dd22
update tools
cpetig Apr 17, 2025
a95a3aa
proper handling of MaybeUninit
cpetig Apr 22, 2025
26bd901
proper handling of stream copy/ctor
cpetig Apr 22, 2025
3ba8e4c
handle inconsistent waiting states
cpetig Apr 22, 2025
378e64d
store closed handling separately from data
cpetig Apr 22, 2025
ceb2551
future lifting option
cpetig Apr 24, 2025
6342519
implement the changed interface (in progress)
cpetig Apr 24, 2025
1b06421
keep pattern approach for the callback
cpetig May 1, 2025
07d710e
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig May 1, 2025
c5c98a7
avoid Alex latest changes to wasm-tools for now
cpetig May 2, 2025
c8e738b
close to working again
cpetig May 2, 2025
d976667
fix limbo state of executor
cpetig May 2, 2025
fe285f8
correct wrongly generated code
cpetig May 2, 2025
49ff78a
lift and lower support on futures
cpetig May 2, 2025
d6a91d8
more complete future lifting and lowering support
cpetig May 2, 2025
5cc17c3
new string test
cpetig May 2, 2025
947f236
example with stream lifting and lowering
cpetig May 3, 2025
5d5dcd1
empty skeleton
cpetig May 3, 2025
a082c1b
cargo fmt, finish include
cpetig May 3, 2025
334e937
stream string example
cpetig May 3, 2025
5b21e37
rustfmt
cpetig May 3, 2025
976376d
fully linking future test
cpetig May 3, 2025
46c3931
fully working string future test
cpetig May 3, 2025
4782f3c
use vtables like the original
cpetig May 3, 2025
df4220d
adapt to new layout
cpetig May 3, 2025
19fa632
rename to proper name
cpetig May 3, 2025
09721df
stream of strings
cpetig May 3, 2025
9defe39
fmt
cpetig May 3, 2025
681d333
a fully linking string stream example
cpetig May 3, 2025
72cdf1e
fully operational string stream example
cpetig May 3, 2025
ee27d1a
cargo fmt
cpetig May 3, 2025
a3cf264
fix rust stream example
cpetig May 3, 2025
c03dcbd
stream lifting and lowering, more elegant than Rust
cpetig May 3, 2025
ef54014
fix compilation of executor
cpetig May 5, 2025
2782719
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig May 7, 2025
425a75a
update bindings
cpetig May 7, 2025
402e474
fix warning
cpetig May 7, 2025
41b6f4d
more fixed size implementation
cpetig Apr 19, 2025
df55ccd
more fixed list implementation
cpetig Apr 19, 2025
f87010d
cargo fmt
cpetig Apr 19, 2025
c70113e
test passes with modified wasmtime
cpetig Apr 20, 2025
0d57981
document and compare test
cpetig Apr 20, 2025
6cbbad6
returning a fixed size list works
cpetig Apr 20, 2025
a9ea6b0
re-enable normal parameters
cpetig Apr 20, 2025
6c94bf2
clean up and use wac fork
cpetig Apr 20, 2025
8e4235e
another testcase passing
cpetig Apr 20, 2025
0e17f59
oh, two failing tests
cpetig Apr 20, 2025
4138036
initial c++ skeleton
cpetig Apr 20, 2025
e55da99
reduce code (no host, no symmetric)
cpetig Apr 20, 2025
1547c53
c++ generator compiles
cpetig Apr 21, 2025
e6a3e44
skeletal c++ testing support
cpetig Apr 27, 2025
a807a30
proper include
cpetig Apr 27, 2025
013633c
post merge fixes
cpetig May 7, 2025
984e9a2
c++ numbers test works
cpetig May 8, 2025
c8a7e11
many-arguments c++ test works
cpetig May 8, 2025
e741941
more test changes
cpetig May 8, 2025
2ccd752
records test passes
cpetig May 10, 2025
a17ab72
records test passes for c++
cpetig May 10, 2025
0bb5a03
numbers ok with c++17
cpetig May 10, 2025
a4cae5d
many arguments cover both sides
cpetig May 10, 2025
1b8574e
strings test passes
cpetig May 10, 2025
7ff30cb
fix options test
cpetig May 10, 2025
66bb0c6
fix old string test
cpetig May 10, 2025
ca017da
list test (in progress)
cpetig May 10, 2025
e7ad032
fix list test
cpetig May 10, 2025
f077354
incomplete results test
cpetig May 10, 2025
3f8a7b6
better variant support
cpetig May 13, 2025
77afda0
small fix
cpetig May 13, 2025
c3621c5
use c++17 to compile
cpetig May 13, 2025
515c4ea
clarify EOF logic
cpetig May 13, 2025
1683340
handle no data when polling
cpetig May 13, 2025
4a2bd49
handle negative difference in debug display
cpetig May 13, 2025
33525ad
link to either symmetric or canonical runtime
cpetig May 13, 2025
148b9eb
remove unnecessary move
cpetig May 18, 2025
b3ed215
variant lowering
cpetig May 18, 2025
3f34046
correct record lifting
cpetig May 18, 2025
6bd2c34
fix variant lifting
cpetig May 18, 2025
4c6cd5c
results test passing (but incomplete)
cpetig May 18, 2025
502d35e
results test fully operational
cpetig May 18, 2025
7c2e9f2
Opt out of language C++17 for cpp extension
cpetig May 18, 2025
dca3cd8
variants work
cpetig May 18, 2025
fcd9cea
variants runner works
cpetig May 18, 2025
04637a6
clean up lists test
cpetig May 18, 2025
fe8c0de
I need a better strategy to copy the headers to the target
cpetig May 19, 2025
13c97af
not elegant but working solution
cpetig May 19, 2025
dbdfb71
working resources
cpetig May 23, 2025
3d0c1fe
more complex resource test
cpetig May 23, 2025
1ca600d
remove unused functions
cpetig May 23, 2025
f875e2b
generate template files in the output directory
cpetig May 23, 2025
ac4d022
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 2, 2025
cd6c8f9
simplifications and clippy fixes
cpetig Jun 2, 2025
bb600b8
this was never meant to be checked in
cpetig Jun 2, 2025
91ca5de
cargo fmt again
cpetig Jun 2, 2025
6926a23
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 4, 2025
d8238cc
Merge branch 'cpp-bindgen' of github.com:cpetig/wit-bindgen into work…
cpetig Jun 5, 2025
5f0ad9b
cargo fmt and fixes
cpetig Jun 5, 2025
47f422c
update and fixes
cpetig Jun 6, 2025
56ffc83
mostly working runtime tests again
cpetig Jun 7, 2025
6efb808
all standard tests pass again, symmetric test skeleton
cpetig Jun 7, 2025
449b47f
adapt to symmetric
cpetig Jun 8, 2025
9530b73
link_name, test links
cpetig Jun 9, 2025
846fb06
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 12, 2025
5b12dba
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 12, 2025
f76a8f3
more proper symmetric abi signature
cpetig Jun 12, 2025
4aa589e
fix many warnings and compilation of some tests
cpetig Jun 12, 2025
0ba43ab
simplify stream of strings example
cpetig Jun 14, 2025
be25681
minimize the differences between symmetric and canonical
cpetig Jun 14, 2025
00a0341
use the new symmetric rt compatibility crate
cpetig Jun 14, 2025
f660bbe
symmetric vtable support
cpetig Jun 14, 2025
2a4e676
fix lifting casts
cpetig Jun 14, 2025
5a59e64
upgrade wit-bindgen dependency
cpetig Jun 14, 2025
bb141c6
reduce differenced between symmetric and canonical
cpetig Jun 14, 2025
5c084b0
stream_simple compiles, no test though
cpetig Jun 14, 2025
cfe03bc
simple future compiles
cpetig Jun 14, 2025
1d581e7
future-string works
cpetig Jun 14, 2025
510b79e
re-use abi buffer and waitable
cpetig Jun 14, 2025
98b0b9c
shared abi buffer
cpetig Jun 14, 2025
8872b60
execute symmetric tests
cpetig Jun 16, 2025
af2588c
c++ symmetric linking but not running
cpetig Jun 16, 2025
db6a3e6
working pure c++ symmetric test
cpetig Jun 16, 2025
5411697
add bitflags (needed by flags)
cpetig Jun 17, 2025
ad02150
fix several symmetric tests
cpetig Jun 17, 2025
b84a3e9
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 17, 2025
c88a079
use fixed wasm-tools
cpetig Jun 17, 2025
26036d6
link name fixes
cpetig Jun 17, 2025
5585b08
c++ future test
cpetig Jun 18, 2025
9460735
regenerate rust binding
cpetig Jun 18, 2025
6adf63b
link name
cpetig Jun 18, 2025
9068a97
regenerated bindings
cpetig Jun 18, 2025
840faaf
linking c++ future test
cpetig Jun 19, 2025
ea7de9a
optionally output the commands (WIT_BINDGEN_TRACE), hide C++ symbol c…
cpetig Jun 19, 2025
688ed17
implement short cut at registration
cpetig Jun 19, 2025
029effd
simplify executor code
cpetig Jun 19, 2025
2d0edd3
cleanup + direct progress on subscription
cpetig Jun 19, 2025
7556398
small but important correction
cpetig Jun 19, 2025
0f7fc22
c++ future string works
cpetig Jun 19, 2025
95cd7d8
correct payload size
cpetig Jun 19, 2025
21a8f36
fix publishing logic
cpetig Jun 20, 2025
98b43e3
attempt to use waitable
cpetig Jun 21, 2025
1473d11
trying to thread the subscription through the executor call stack
cpetig Jun 21, 2025
5cbd175
fmt
cpetig Jun 21, 2025
1a80393
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 21, 2025
1f91c8d
Merge branch 'cpp-bindgen' into work-in-progress
cpetig Jun 21, 2025
676931b
turn on trace in the tests for now
cpetig Jun 21, 2025
3312272
abstract the low level interaction with the waker
cpetig Jun 21, 2025
49c4ff1
regenerate test
cpetig Jun 21, 2025
75b68fd
regenerate the other future example
cpetig Jun 21, 2025
72e43d8
waitable didn't fit well enough
cpetig Jun 22, 2025
a7d3b02
revert changes to waitable
cpetig Jun 22, 2025
8a7bad4
document ideas
cpetig Jun 22, 2025
439feef
clean the code, make it compile with the newest Rust guest library
cpetig Jun 22, 2025
8602561
make the read start
cpetig Jun 22, 2025
964a9e9
test doesn't end but the values are passed correctly
cpetig Jun 22, 2025
4a763cf
fully operational Rust string streams
cpetig Jun 22, 2025
b65b5de
still some confusion about how the templates are designed but everyth…
cpetig Jun 22, 2025
8aa07a7
cpp runner doesn't exit with rust test, but everything else works
cpetig Jun 22, 2025
80b467f
proper EOF handling in C++
cpetig Jun 22, 2025
0f497d1
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 26, 2025
d45c8d6
simplify logic expression
cpetig Jun 26, 2025
e46cc8d
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jun 26, 2025
734121a
fix test runner
cpetig Jun 26, 2025
ee3371f
fix compilation of symmetric executor
cpetig Jun 26, 2025
2eb785e
sharing types between import and export
cpetig Jun 28, 2025
c7176f4
Merge remote-tracking branch 'cpetig/fixed_size_list' into work-in-pr…
cpetig Jun 28, 2025
3108047
work on fixed size lists
cpetig Jun 30, 2025
dc9e72c
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 12, 2025
3730b37
fix compilation
cpetig Jul 12, 2025
cc57340
not perfect lifting code but a good start
cpetig Jul 12, 2025
a1d365f
clarify command, fix second lowering
cpetig Jul 12, 2025
57ace0e
nested list tests
cpetig Jul 12, 2025
9607e9c
wac support was merged
cpetig Jul 12, 2025
51affb5
make the test more hard for C++
cpetig Jul 12, 2025
9f2268a
Trying to use C arrays (dead end)
cpetig Jul 13, 2025
75d06b7
Revert "Trying to use C arrays (dead end)"
cpetig Jul 13, 2025
6f90a5a
generated code compiles
cpetig Jul 13, 2025
37bc4b1
complete c++ test
cpetig Jul 13, 2025
7412e80
implement missing test
cpetig Jul 13, 2025
5371785
update wasm-tools
cpetig Jul 13, 2025
5cdb249
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 17, 2025
ac20760
correct return value of read, implement Sink
cpetig Jul 17, 2025
ae02bb5
general cleanup
cpetig Jul 17, 2025
5818715
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 18, 2025
a2423fd
correct stream lifting
cpetig Jul 18, 2025
e2a5ecb
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 22, 2025
43dfef0
adapt and simplify C++ example
cpetig Jul 20, 2025
fc07d6f
span include
cpetig Jul 22, 2025
f7eaaa5
implement streams without lift/lower
cpetig Jul 22, 2025
4102a35
unify both wit-bindgen crate variants more
cpetig Jul 24, 2025
6b88726
add block-on to executor and regenerate bindings
cpetig Jul 24, 2025
efa9b97
re-add link name
cpetig Jul 24, 2025
0883dda
enable block on, add IsReadyToWrite, document
cpetig Jul 28, 2025
1c51697
return handle from set_reader, document, clean up
cpetig Jul 28, 2025
87a5329
re-introduce wit::span
cpetig Jul 28, 2025
e280427
add proper constructor
cpetig Jul 28, 2025
efa88d8
use proper constructor for span and stream
cpetig Jul 28, 2025
df23812
write down information about WASI 0.3 decisions for symmetric
cpetig Jul 28, 2025
cce72b8
towards supporting async calls
cpetig Jul 28, 2025
3b578a3
abi::call with proper async
cpetig Jul 28, 2025
bbab370
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 28, 2025
891698d
closer but not close, still result confusion
cpetig Jul 28, 2025
d81147b
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Jul 29, 2025
f8f39dc
fix normal code generation
cpetig Jul 29, 2025
b510bbe
fake the full writing API, write needs more work
cpetig Jul 29, 2025
11f014d
non-blocking write on C++
cpetig Aug 1, 2025
4ba4e52
reduce differences between symmetric and canonical
cpetig Aug 1, 2025
35d02aa
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Aug 11, 2025
8aa4403
update wasmtools
cpetig Aug 15, 2025
cc84ccf
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Aug 15, 2025
8a540c0
Merge branch 'main' of https://github.com/bytecodealliance/wit-bindge…
cpetig Aug 19, 2025
a07b182
fix warnings
cpetig Aug 19, 2025
b9c0710
fix MISRA violation in cabi_realloc
cpetig Aug 19, 2025
3b6f45d
fix part of list test
cpetig Aug 19, 2025
b536a1e
reduce MISRA warnings (in progress)
cpetig Aug 19, 2025
549da3f
dep update
cpetig Aug 21, 2025
ec9e0ae
fix version number for sleep
cpetig Aug 21, 2025
a12d7d1
simplify async function export
cpetig Aug 21, 2025
6cfcbb9
regenerate with newer version
cpetig Aug 21, 2025
b7e0b76
reduced difference
cpetig Aug 21, 2025
994700d
don't generate callback
cpetig Aug 21, 2025
df3105d
simplify signature
cpetig Aug 21, 2025
2b17181
fix async func signature on export
cpetig Aug 21, 2025
6bdbc66
symmetric results are owned
cpetig Aug 21, 2025
e00ce6b
nearly fix invocation of imported async functions
cpetig Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@
[submodule "tests/codegen/wasi-clocks"]
path = tests/codegen/wasi-clocks
url = https://github.com/WebAssembly/wasi-clocks
[submodule "crates/cpp/tests/wasm-micro-runtime"]
path = crates/cpp/tests/wasm-micro-runtime
url = https://github.com/bytecodealliance/wasm-micro-runtime.git
Loading
Loading