-
Couldn't load subscription status.
- Fork 243
Feat/update resources #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/update resources #1397
Conversation
|
Did you intend to make this PR upstream? Currently there are a lot of changes committed throughout that I don't think you meant to upstream, e.g. devcontainer settings, sorting order in Cargo.toml sections, etc |
|
What is a path to update the dependencies to make this PR upstream? |
|
@JADSN1894 as a start, you should add a clear description of what the PR does, and why these changes are needed. Without that, it's very hard for reviewers to evaluate the implementation. |
Thanks for reply. I write a short goals description. |
|
@JADSN1894 at over 2000 lines of miscellaneous changes this PR is not going to merge as-is. Your goals make sense to me, but please split this up into separate PRs that are more focused as opposed to performing large codebase refactorings trying to achieve multiple goals at the same time. |
|
@JADSN1894 to offer some more constructive feedback: it would be good for you to read through the diff you've created and make sure everything makes sense and is meant to be included. In particular, I note that you seem to have done a global find-replace for |
|
Is it better make this PR a draft and try again another way, like split this up into separate PRs? |
|
Splitting up would be preferable yeah, if that's managable. |
Doubts
|
|
Hey @JADSN1894, we really appreciate your work towards improving things here. We also all have fairly limited capacity to help you work through understanding how the system works, unfortunately. I would recommend that you take a step back and go back to the unmodified |
Goals
devcontainersettings image torust:latest(optional)2024at rootCargo.tomlworkspace3at root Cargo.toml workspaceCargo.tomlsectionsAll these changes is to turn the code up-to-date based on stable channel to reduce technical debt and security risks and more organized between all project packages.