(build) fix some compile and conan problems#774
Open
yangzhg wants to merge 1 commit into
Open
Conversation
yangzhg
requested review from
Copilot and
kexianda
and removed request for
Copilot
July 23, 2026 09:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Bolt’s build reliability in strict/isolated toolchain environments by cleaning up obsolete linkage, aligning Conan integration and pinned recipes, adding source mirrors, and introducing a local Conan recipe for the Volcengine TOS C++ SDK.
Changes:
- Add compiler prefix/path mapping flags in CMake to avoid embedding absolute source/build paths in artifacts.
- Improve Conan profile handling/graph info generation in the Makefile; align Arrow/Snappy/RapidJSON-related recipe patches and add Apache/GNU mirror fallbacks.
- Add a full Conan recipe + test_package for
tos_clientacross multiple upstream SDK versions.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/conan/recipes/tos_client/config.yml | Registers multiple tos_client versions for the local recipe. |
| scripts/conan/recipes/tos_client/all/conanfile.py | Adds the Conan recipe for building/packaging the Volcengine TOS C++ SDK. |
| scripts/conan/recipes/tos_client/all/conandata.yml | Defines per-version source URLs and checksums for the TOS SDK archives. |
| scripts/conan/recipes/tos_client/all/test_package/conanfile.py | Adds Conan test_package to validate the exported package via CMake. |
| scripts/conan/recipes/tos_client/all/test_package/CMakeLists.txt | Builds and links a minimal consumer against tos_client::tos_client. |
| scripts/conan/recipes/tos_client/all/test_package/test_package.cpp | Minimal runtime check that exercises a symbol from the SDK. |
| scripts/conan/recipes/paimon-cpp/all/patches/paimon-cpp-conan-deps.patch | Adjusts Snappy discovery/targets and improves Conan/CMakeDeps integration for ExternalProject builds. |
| scripts/conan/patches/source-mirrors-apache.patch | Prepends Huawei Cloud mirrors for selected Apache sources. |
| scripts/conan/patches/gnu-source-mirrors.patch | Prepends kernel.org mirrors for required GNU sources. |
| scripts/conan/patches/pkgconf-2.2.0-fix-gnu99.patch | Ensures pkgconf is built with GNU99 extensions as required by its sources. |
| scripts/conan/patches/arrow.15.0.1-csv-support.patch | Aligns Arrow 15.0.1 options/targets and fixes Snappy/RapidJSON-related integration details. |
| Makefile | Consumes externally supplied Conan host/build profiles and aligns conan graph info args with install. |
| conanfile.py | Aligns Arrow options with the pinned Arrow recipe (e.g., acero, legacy hdfs_bridgs). |
| CMakeLists.txt | Adds file-prefix-map support and removes obsolete stdc++fs linkage while standardizing GCC>=10. |
| bolt/substrait/tests/CMakeLists.txt | Removes ${FILESYSTEM} linkage from tests. |
| bolt/jit/tests/CMakeLists.txt | Removes ${FILESYSTEM} linkage from tests. |
| bolt/dwio/txt/tests/CMakeLists.txt | Removes ${FILESYSTEM} linkage from tests. |
| bolt/dwio/parquet/tests/CMakeLists.txt | Removes ${FILESYSTEM} linkage from tests. |
| bolt/dwio/dwrf/test/utils/CMakeLists.txt | Removes legacy GCC<9 stdc++fs linkage workaround. |
| bolt/dwio/dwrf/test/CMakeLists.txt | Removes ${FILESYSTEM} linkage from tests. |
| bolt/dwio/common/tests/utils/CMakeLists.txt | Removes legacy GCC<9 stdc++fs linkage workaround. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Bolt builds in strict or isolated toolchain environments exposed several build and dependency-management issues:
Issue Number: N/A
Type of Change
Description
This PR improves Bolt build compatibility across different compiler, sysroot, and Conan environments:
Validation performed:
Performance Impact
Release Note
Release Note:
Release Note:
Checklist (For Author)
Breaking Changes