refactor: measure splitTime in doSplit and shuffleWriteTime at operator level#783
Open
HaoChen-ch wants to merge 2 commits into
Open
refactor: measure splitTime in doSplit and shuffleWriteTime at operator level#783HaoChen-ch wants to merge 2 commits into
HaoChen-ch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Measure splitTime directly. Replace the subtraction with a dedicated NanosecondTimer splitTimer(&splitTime_) scoped to the real split work inside doSplit() (buildPartition2Row + preAlloc + splitRowVector). finalizeMetrics() now simply assigns metrics_.splitTime= splitTime_.
Measure shuffleWriteTime at the operator level. Move it into SparkShuffleWriter (ShuffleWriterNode), wrapping addInput (split), reclaim (spill) and noMoreInput→stop. It now reflects the full wall time of the shuffle-write operator (init + addInput + reclaim + stop) instead of just split + stop.
Narrow the flattenTime scope. Tighten the NanosecondTimer(&flattenTime_) blocks so they cover only the flatten calls (ensureFlatten / ensurePartialFlatten / ensureVectorLoaded), excluding the subsequent split/evict logic.
Remove the now-unused totalSplitTime_ and stopTime_ members and their timers in split() / stop() across all three writers.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes