fix(sandbox): prevent URLs in bash commands from being flagged as unsafe paths#1468
Open
alumpzs wants to merge 2 commits intobytedance:mainfrom
Open
fix(sandbox): prevent URLs in bash commands from being flagged as unsafe paths#1468alumpzs wants to merge 2 commits intobytedance:mainfrom
alumpzs wants to merge 2 commits intobytedance:mainfrom
Conversation
…afe paths The absolute path regex falsely matched URL path components (e.g. //example.com from https://...) as local filesystem paths, causing skill invocations with domainUrl parameters to fail with "Unsafe absolute paths" errors. Fix: before running the absolute-path regex, strip URLs that use whitelisted schemes (https, http, ftp, s3, gs, data) from the command string. The URL pattern uses a word-boundary lookbehind to avoid substring matches (e.g. tftp, ahttps) and is case-insensitive. Dangerous protocols like file://, gopher://, dict:// are intentionally excluded from the whitelist so they remain subject to path validation.
alumpzs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The absolute path regex falsely matched URL path components (e.g. //example.com from https://...) as local filesystem paths, causing skill invocations with domainUrl parameters to fail with "Unsafe absolute paths" errors.
Fix: before running the absolute-path regex, strip URLs that use whitelisted schemes (https, http, ftp, s3, gs, data) from the command string. The URL pattern uses a word-boundary lookbehind to avoid substring matches (e.g. tftp, ahttps) and is case-insensitive. Dangerous protocols like file://, gopher://, dict:// are intentionally excluded from the whitelist so they remain subject to path validation.