fix: improve PPT generation skill loading for agent#1471
Open
jjjojoj wants to merge 1 commit intobytedance:mainfrom
Open
fix: improve PPT generation skill loading for agent#1471jjjojoj wants to merge 1 commit intobytedance:mainfrom
jjjojoj wants to merge 1 commit intobytedance:mainfrom
Conversation
Fix issue bytedance#424 - agent does not load ppt-generation skill proactively Root cause (Lntanohuang's analysis): - Agent's strong CLARIFY → PLAN → ACT system prompt causes it to ask clarifying questions before loading the ppt-generation skill - Skill matching is fully passive (prompt-guided) — the agent must recognize and read_file SKILL.md on its own, which weaker models fail to do - PR bytedance#1171 only addressed Path B fallback for missing GEMINI_API_KEY Changes: - Add SKILL-FIRST PRIORITY section in get_skills_prompt_section() with explicit PPT keyword table and immediate skill loading directive - Add 'Skill-First Priority' reminder in critical_reminders section - Specify exact skill path /mnt/skills/public/ppt-generation/SKILL.md - Instruct agent to NOT ask clarification (style/slide count) — skill has reasonable defaults and handles parameters itself - Bilingual keywords: English + Chinese (幻灯片, 生成PPT, 制作PPT) This makes PPT generation requests recognized and acted upon immediately, bypassing the CLARIFY step that caused re-planning loops.
|
|
Collaborator
|
@jjjojoj thanks for your contribution, please click the CLA button to sign the CLA first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #424: PPT generation fails because the agent enters a
CLARIFY → PLAN → ACTloop instead of directly loading theppt-generationskill.As analyzed by @Lntanohuang in issue #424, the root cause is:
SKILL.md— weaker models (e.g. doubao) often fail to do this reliablyGEMINI_API_KEYbut did not address proactive skill loadingChanges
Modified
backend/packages/harness/deerflow/agents/lead_agent/prompt.py:1.
get_skills_prompt_section()— added SKILL-FIRST PRIORITY block:/mnt/skills/public/ppt-generation/SKILL.md2.
<critical_reminders>— added Skill-First Priority reminder:Result
Closes #424