Skip to content

improve error messages for common config mistakes - #75

Merged
AllanChain merged 1 commit into
mainfrom
fix/cfg-error-msg
Jul 24, 2026
Merged

improve error messages for common config mistakes#75
AllanChain merged 1 commit into
mainfrom
fix/cfg-error-msg

Conversation

@AllanChain

Copy link
Copy Markdown
Member

This covers the main confusing cases: missing required key, bad module paths, and malformed CLI overrides like key without =.

Unused config keys now produce direct JaQMC errors instead of a generic stop or mixed raw exceptions.

@AllanChain
AllanChain enabled auto-merge (squash) July 24, 2026 11:02
@codecov-commenter

codecov-commenter commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.41176% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (6dee554) to head (d80e249).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/jaqmc/utils/config.py 77.41% 3 Missing and 4 partials ⚠️
src/jaqmc/utils/module_resolver.py 95.45% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.02%     
==========================================
  Files         163      163              
  Lines        8775     8833      +58     
  Branches      933      946      +13     
==========================================
+ Hits         7851     7902      +51     
- Misses        602      605       +3     
- Partials      322      326       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This covers the main confusing cases: missing required key, bad module
paths, and malformed CLI overrides like `key` without `=`.

Unused config keys now produce direct JaQMC errors instead of a generic
stop or mixed raw exceptions.
@AllanChain
AllanChain merged commit 77c71d0 into main Jul 24, 2026
13 checks passed
@AllanChain
AllanChain deleted the fix/cfg-error-msg branch July 24, 2026 12:17
AllanChain added a commit that referenced this pull request Jul 24, 2026
Follow up to #74 and #75: checkpoint-free analytic evaluation makes
`workflow.source_path` optional, superseding the required-field
assertions. Remove the stale CLI check and verify omitted values resolve
to `None.`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants