-
Notifications
You must be signed in to change notification settings - Fork 5
Clarify guidance issue280 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| The C2PA Technical Working Group may approve and merge PRs in accordance with its prevailing processes for approving technical contributions to the C2PA specification. | ||
|
|
||
| C2PA's Technical Working Group may also decide to remove malicious or non-conformant algorithms from the list of approved soft binding algorithms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how it is going to be determined if an algorithm is malicious or non-conformant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @alexandersolonskycastlabs and @jcollomosse, how about:
| C2PA's Technical Working Group may also decide to remove malicious or non-conformant algorithms from the list of approved soft binding algorithms. | |
| C2PA's Technical Working Group may also decide to remove malicious or non-conformant entries from the list of approved soft binding algorithms. |
and I will add more precise criteria below in the "selection rules" section.
|
Agreed, I think this should refer to a non-conformant entry i.e. to the
SBAL schema, and malicious in the context of spam or harmful entries to the
list rather than an algorithm and its function
…On Fri, 28 Nov 2025, 12:30 alexandersolonskycastlabs, < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#36 (comment)>
:
> @@ -1,9 +1,25 @@
# Soft Binding Algorithm List
-C2PA specifies a mechanism for recovering a C2PA Manifest for an asset, for example when the metadata containing the C2PA Manifest has been stripped. This mechanism is a [soft binding](https://c2pa.org/specifications/specifications/2.0/specs/C2PA_Specification.html#_soft_binding) (for example an invisible watermark or content fingerprint). The soft binding is used to look-up the C2PA Manifest within a Manifest Repository. The soft binding is described by the [soft binding assertion](https://c2pa.org/specifications/specifications/2.0/specs/C2PA_Specification.html#_soft_bindings).
+C2PA specifies a mechanism for recovering a C2PA Manifest for an asset, for example when the metadata containing the C2PA Manifest has been stripped. This mechanism is a [soft binding](https://c2pa.org/specifications/specifications/2.0/specs/C2PA_Specification.html#_soft_binding), for example an invisible watermark or content fingerprint. The soft binding is used to look-up the C2PA Manifest within a Manifest Repository. The soft binding is described by the [soft binding assertion](https://c2pa.org/specifications/specifications/2.0/specs/C2PA_Specification.html#_soft_bindings).
+
+The soft binding assertion contains a field `alg` uniquely identifies the algorithm used to compute the soft binding. The Soft Binding Algorithm List is an authoritative list of soft binding algorithm names that may be used as identifiers within the `alg` field. Entries in the list also contain additional information on the algorithms.
+
+## Guidelines for submitting a new entry
+
+### Pull request
+Developers of soft binding algorithms may request these be added as new entries in the soft binding algorithm list. Developers may also request amendments to their entries. These requests may be made by submitting a Pull Request (PR) adding to or editing the [softbinding-algorithm-list JSON array](softbinding-algorithm-list.json) in this repository and following the [schema](softbinding-algorithm-list-schema.json).
+
+### Selection rules
+
+The C2PA Technical Working Group may approve and merge PRs in accordance with its prevailing processes for approving technical contributions to the C2PA specification.
+
+C2PA's Technical Working Group may also decide to remove malicious or non-conformant algorithms from the list of approved soft binding algorithms.
how it is going to be determined if an algorithm is malicious or
non-conformant?
—
Reply to this email directly, view it on GitHub
<#36 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYLIHAUY6SSRWZBEB73GL337A56LAVCNFSM6AAAAACNO25F52VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMJYHAYDEOJZG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
README.md
Outdated
| ## Guidelines for submitting a new entry | ||
|
|
||
| ### Pull request | ||
| Developers of soft binding algorithms may request these be added as new entries in the soft binding algorithm list. Developers may also request amendments to their entries. These requests may be made by submitting a Pull Request (PR) adding to or editing the [softbinding-algorithm-list JSON array](softbinding-algorithm-list.json) in this repository and following the [schema](softbinding-algorithm-list-schema.json). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it have to be the developer? What if a user of an open source algorithm would like it added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lrosenthol it does not need to be a developer but should be someone who is affiliated with the company. As for an opensource algorithm only forks will work as otherwise there would be X times the same entry and that would not be interoperable. In the case of a fork the owner of the fork should submit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of:
| Developers of soft binding algorithms may request these be added as new entries in the soft binding algorithm list. Developers may also request amendments to their entries. These requests may be made by submitting a Pull Request (PR) adding to or editing the [softbinding-algorithm-list JSON array](softbinding-algorithm-list.json) in this repository and following the [schema](softbinding-algorithm-list-schema.json). | |
| Owners of soft binding algorithms may request these be added as new entries in the soft binding algorithm list. Owner may also request amendments to their entries. These requests may be made by submitting a Pull Request (PR) adding to or editing the [softbinding-algorithm-list JSON array](softbinding-algorithm-list.json) in this repository and following the [schema](softbinding-algorithm-list-schema.json). A request has to be submitted by an individual affiliated with the company owning the submitted proprietary algorithm or a maintainer of the submitted open source algorithm or its fork. |
|
|
||
| For an entry to be approved the following criteria are important: | ||
| - The entry has to comply with the [schema](softbinding-algorithm-list-schema.json) and include all the mendatory fields. | ||
| - The PR has to be sumitted by a representative of the named technology (e.g., the commercial vendor, or open source repository maintainer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this requirement...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lrosenthol - we should not allow anyone to submit any algorithm. Someone not affiliated with company X should not be able to submit an entry for company X as company X might not want their algorithm to be listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @jcollomosse @alexandersolonskycastlabs comments above:
| - The PR has to be sumitted by a representative of the named technology (e.g., the commercial vendor, or open source repository maintainer). | |
| For a PR (new entry or update) to be approved the following criteria are important: | |
| - The entry has to conform with the [schema](softbinding-algorithm-list-schema.json) and include all the mandatory fields. | |
| - The entry should not be malicious (e.g., spam) or harmful. | |
| - The PR has to be submitted by an individual affiliated with the company owning the submitted proprietary algorithm or a maintainer of the submitted open source algorithm or its fork. |
Co-authored-by: Leonard Rosenthol <[email protected]>
Co-authored-by: Leonard Rosenthol <[email protected]>
jcollomosse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I support it but I feel like this is policy position that ought to be run past TWG and/or @lrosenthol before merging.
No description provided.