Open
Conversation
This allows users to override the default expiry behavior when using DynamoDB TTL to expire sessions from the table. This would be useful, for example, if they wanted to use a browser session scoped cookie as the session cookie (with no maxAge attribute) but needed a shorter TTL than the default '1 day from now'. If this parameter is not provided then there will be no change to the current behaviour.
Draft
2 tasks
liegeandlief
suggested changes
Jul 2, 2025
liegeandlief
suggested changes
Jul 2, 2025
alex9smith
force-pushed
the
feat/add-expiresin-option
branch
from
1983837 to
c689574
Compare
liegeandlief
suggested changes
Jul 2, 2025
alex9smith
force-pushed
the
feat/add-expiresin-option
branch
from
c689574 to
2557bbf
Compare
alex9smith
force-pushed
the
feat/add-expiresin-option
branch
from
2557bbf to
825094c
Compare
liegeandlief
suggested changes
Jul 2, 2025
alex9smith
force-pushed
the
feat/add-expiresin-option
branch
from
825094c to
c703835
Compare
liegeandlief
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Looks good to me, nice one for getting it done so quickly 🎸 Hopefully @ca98am79 will be able to take a look soon 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to override the default expiry behavior when using DynamoDB TTL to expire sessions from the table. This would be useful, for example, if they wanted to use a browser session scoped cookie as the session cookie (with no maxAge attribute) but needed a shorter TTL than the default '1 day from now'.
If this parameter is not provided then there will be no change to the current behaviour. I think that means this can be released as a minor version change.