Skip to content

Elytra in overworld (pt2)#5015

Open
underscore-zi wants to merge 46 commits intocabaletta:1.19.4from
underscore-zi:1.19.4
Open

Elytra in overworld (pt2)#5015
underscore-zi wants to merge 46 commits intocabaletta:1.19.4from
underscore-zi:1.19.4

Conversation

@underscore-zi
Copy link
Copy Markdown

Continues off the work in #4698
Closes #4187

underscore-zi and others added 30 commits March 15, 2025 03:32
…ilize height map to save some cycles if player is flying above ground.
@underscore-zi
Copy link
Copy Markdown
Author

underscore-zi commented Apr 28, 2026

There are a few new commits since the last update in the old PR. Still addressing that same lag issues I was encountering. I managed to get a local reproducer and trace it down in more detail.

Fix is split across three commits:

  1. Skipping the tick instead of blocking if the nether-pathfinder read lock isn't available. Not the nicest solution but there isn't a clean way I could think of to do any work without read access.
  2. Searching for a landing spot will split its work across multiple ticks instead of blocking. This was an especially noticeable issue when flying over lava pools or oceans and chunk loading was slow.
  3. Not blocking while hoping async solveAngles call will complete. There was 250ms timeout (I added that to prevent deadlocking) on the get for that future. In the worst case scenario this would block for 250ms, fail, and then repeat the work synchronously.

The third point is the one that I feel the least confident in as a solution. I've tested it, and not noticed any new issues, in-fact it feels a bit smoother during some tighter flights though that could just be in my head.

[0] Sample of the choppy flight experience:

choppy-flight.mp4

[1] Fixed/smooth flight:

smooth-flight.mp4

@LHM056awa
Copy link
Copy Markdown

Nice feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for auto-flight with Elytras in the overworld and the End.

3 participants