Skip to content

feat: updating desktopCapturer to support system audio capture. - #243

Open
UUoocl wants to merge 2 commits into
cables-gl:developfrom
UUoocl:develop
Open

feat: updating desktopCapturer to support system audio capture.#243
UUoocl wants to merge 2 commits into
cables-gl:developfrom
UUoocl:develop

Conversation

@UUoocl

@UUoocl UUoocl commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Adding system audio capture. The desktopCapturer module supports audio capture. This pull request enables the desktopCapturer audio option.
macOS entitlement requests are included in the package.json.
The macOS speech recognition entitlement request is included for an Op in development.

-made with google antigravity

@steam0r

steam0r commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

hey, this looks great! a few nitpicks:

  • can you remove the console logs in _getRawDesktopSources? this feels a bit "noisy"
  • will this not work on linux? any reason for this check if (process.platform === "darwin" || process.platform === "win32")

thanks!

@UUoocl

UUoocl commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing this pull request.
I removed the console log from the successful try case, do you think the console log in the error case should be removed too?

I haven't setup a linux system to test if this works in linux. Google Gemini reported that natively capturing system audio via Electron's desktopCapturer module does not work on Linux. The issue is in the Chrome Embedded Framework in Linux. Capturing video should work in MacOS, Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants