battery: Integrated tlp for power profile switching#1273
Open
Kalagmitan wants to merge 7 commits intocaelestia-dots:mainfrom
Open
battery: Integrated tlp for power profile switching#1273Kalagmitan wants to merge 7 commits intocaelestia-dots:mainfrom
Kalagmitan wants to merge 7 commits intocaelestia-dots:mainfrom
Conversation
+ Implemented the ability to switch between power profiles depending on the power management backend, in this case, tlp or power-profiles-daemon (ppd). + Added an abstraction layer that checks whether the user uses tlp or ppd, and depending on which one, it will use the corresponding commands for that backend to switch between power profiles. + The abstraction layer can be potentially expanded upon to include more commands from tlp to be hooked to some tab in the settings to leverage its insane battery customizability. Some Limitations: + If one changes the power management backend for some reason, the shell will not react to it (it's a waste of performance to make it so). The shells needs to be restarted to make it see the switch. + Switching power profiles while on tlp will require a password prompt to gain sudo because tlp works differently from ppd, because of this, the UX may feel off. The only solution to this is to make the user (or installation script) modify the sudoer file so tlp can just run unrestricted. I'll leave this as is for now tho.
6e2611b to
6a454df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Limitations:
hi.mp4