Skip to content

feat: Fullscreen notification & toasts overlay#1276

Open
PixelKhaos wants to merge 26 commits intocaelestia-dots:mainfrom
PixelKhaos:fullscreen-notifs
Open

feat: Fullscreen notification & toasts overlay#1276
PixelKhaos wants to merge 26 commits intocaelestia-dots:mainfrom
PixelKhaos:fullscreen-notifs

Conversation

@PixelKhaos
Copy link
Contributor

@PixelKhaos PixelKhaos commented Mar 13, 2026

No more missing a low battery toast because of watching a movie in fullscreen!

Edited; approach is now more of transforming the shell between normal and fullscreen modes.
Slide and width/thickness animated instead of fades.

configured like so

"notifs": {
   "fullscreen": "off"
},
"toasts": {
   "fullscreen": "all"
}

Also added the toast and notification config options into a new controlcenter pane

recording_20260316_07-57-47.mp4

@evertiro
Copy link
Contributor

Nice!

@PixelKhaos PixelKhaos marked this pull request as draft March 15, 2026 22:30
@PixelKhaos
Copy link
Contributor Author

With this newest approach, I am considering how or if any drawers should be able to be enabled, i.e dash or launcher? Most is easiest to just access via a special workspace, or just switching workspace real quick.
Not much of a point to have the launcher on fullscreened ws even with scrolling layout

@soramanew
Copy link
Collaborator

Yeah we might want to completely disable the launcher when fs actually to prevent accidental opens

@PixelKhaos PixelKhaos marked this pull request as ready for review March 17, 2026 04:03
@PixelKhaos
Copy link
Contributor Author

Yeah we might want to completely disable the launcher when fs actually to prevent accidental opens

Yeah, I think it's best to leave any drawers alone when in fs, any drawers opening at all could interfere, and it's not really worth putting any effort into allowing it as there's nothing to gain.

But otherwise, I think this is pretty solid as is, the animation matches the vibe more than just fading out

@evertiro
Copy link
Contributor

Yeah we might want to completely disable the launcher when fs actually to prevent accidental opens

Yeah, I think it's best to leave any drawers alone when in fs, any drawers opening at all could interfere, and it's not really worth putting any effort into allowing it as there's nothing to gain.

But otherwise, I think this is pretty solid as is, the animation matches the vibe more than just fading out

I've accidentally opened the launcher in a game so many times, I've actually considered writing a PR to disable it in fullscreen.

Copy link
Collaborator

@soramanew soramanew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these side by side instead of above each other:
image

Also, the border rounding should animate to 0 when going to a fullscreen window (we don't want the corner rounding showing over fullscreen windows, or at least make it an option). And we also need to animate the shadow to 0 so we don't see it over the edges of the screen.

Other than that, looks good!

@PixelKhaos
Copy link
Contributor Author

PixelKhaos commented Mar 19, 2026

Please make these side by side instead of above each other:

I was initially thinking this would have a lot more settings and though that one column being so much taller would be a bit off, but with how it really just two sections yeah it makes more sense
image

Also, the border rounding should animate to 0 when going to a fullscreen window (we don't want the corner rounding showing over fullscreen windows, or at least make it an option). And we also need to animate the shadow to 0 so we don't see it over the edges of the screen.

Done and done.

@PixelKhaos PixelKhaos requested a review from soramanew March 19, 2026 12:34
Copy link
Collaborator

@soramanew soramanew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good to me! Other than the few comments, please merge main into this and make sure it works with the new <2 border fixes. Thanks!

@PixelKhaos
Copy link
Contributor Author

This looks mostly good to me! Other than the few comments, please merge main into this and make sure it works with the new <2 border fixes. Thanks!

Yeah, works fine with the border fixes, nothing needed to be changed there :)

@PixelKhaos PixelKhaos requested a review from soramanew March 20, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants