Change the way activity for one image is integrated#54
Open
ecobost wants to merge 7 commits intocajal:masterfrom
Open
Change the way activity for one image is integrated#54ecobost wants to merge 7 commits intocajal:masterfrom
ecobost wants to merge 7 commits intocajal:masterfrom
Conversation
… the image was shown (before we used a hamming window of size 1 secs)
Member
|
The changes you propose would break all previous processing methods. Why did you decide against using a simple boxcar filter instead of the hamming filter? Wouldn't that have achieved the same thing? You trapezoid integration seems more complex than it needs to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, we used a hamming window of size 1 sec to integrate the activity. This uses a rectangular window over the half a second of presentation. Because we record at relatively slow fps (6-10), half a second of recording will only have 3-5 samples and using a weighted window (like hamming) will waste a good bit of info.