Integrate new design mockup with ViewModel #2653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistency and update related occurrences across codebase
…rt for BTC & refactor wallet type/token checks in view model
…sit/withdraw actions, and integrate Lightning transaction creation with updated priority handling
…in Lightning wallet integration in workflows
…flow for Bitcoin Lightning integration
…htning-specific functionality
…ementations across wallet types
… logic, add Bitcoin Lightning deposit/withdraw support
…ate the default LNURL domain
…t transaction direction logic
… consistency and update related occurrences across codebase
…rt for BTC & refactor wallet type/token checks in view model
…sit/withdraw actions, and integrate Lightning transaction creation with updated priority handling
…in Lightning wallet integration in workflows
…ementations across wallet types
… logic, add Bitcoin Lightning deposit/withdraw support
…ate the default LNURL domain
…t transaction direction logic
…nto new-design-mockup-integration
* feat: add Lightning Network support for Bitcoin wallets * refactor: rename `fiatConvertationStore` to `fiatConversionStore` for consistency and update related occurrences across codebase * feat: enhance address validation with Lightning Network invoice support for BTC & refactor wallet type/token checks in view model * feat: add support for Lightning invoice detection, refactor MWEB deposit/withdraw actions, and integrate Lightning transaction creation with updated priority handling * feat: add method to retrieve unused Spark deposit address for Bitcoin wallets * feat: add Breez API key support and update secrets handling for Bitcoin Lightning wallet integration in workflows * chore: update Breez SDK dependency to version 0.3.4 in pubspec files * Add bitcoin secrets config [skip ci] * feat: extend Lightning wallet functionality with transaction history fetching * feat: add LNURL-pay address detection and support in address parsing flow for Bitcoin Lightning integration * refactor: simplify `ReceivePageOption` logic * refactor: centralize `PaymentURI` generation logic across wallet types * feat: enhance `PaymentURI` handling with asynchronous support and Lightning-specific functionality * refactor: streamline `PaymentURI` logic and remove redundant URI implementations across wallet types * refactor: remove redundant debug print statement from `bitcoin_wallet_addresses.dart` * refactor: improve consistency in widget styling and centralized label logic, add Bitcoin Lightning deposit/withdraw support * feat: reload balance and tx history after sending a lightning transaction * feat: improve address formatting for human-readable addresses and update the default LNURL domain * fix: merge conflicts * feat: add error handling for LightningWallet initialization and adjust transaction direction logic * feat: enable private transactions by default in LightningWallet and update Breez SDK version to 0.4.2 * minor fixes [skip ci] * chore: fix some minor issues in comments (#2654) Signed-off-by: black5box <[email protected]> * fix: handle send-all functionality for LightningWallet transactions and adjust amount calculation logic * fix-german (#2659) * chore: update German localization strings for consistency and accuracy * chore: update German localization strings for consistency and accuracy [skip-ci] * feat: add LNURL support for address validation and LightningWallet compatibility, enhance error handling for OpenCryptoPay * fix: adjust LightningWallet amount parsing from 9 to 8 decimal places * feat: add LNURL support in LightningPaymentRequest and LightningWallet * Fix navigation gradient (#2657) * Fix navigation gradient * Fix CONFIG_ARGS formatting in app_config.sh (#2660) * fix: block wrongly parsed addresses (#2656) * fix: block wrongly parsed addresses * fix: move parsed address check into handlePaymentFlow method * fix: Handle QR URLs separately for pay anything flow * feat: add electrum seed support for Lightning * refactor: improve `parseFixed` logic and add comprehensive unit tests for edge cases (#2661) * Update cw_bitcoin/lib/bitcoin_wallet.dart [skip ci] * resolve conflict issue --------- Signed-off-by: black5box <[email protected]> Co-authored-by: Omar Hatem <[email protected]> Co-authored-by: black5box <[email protected]> Co-authored-by: tuxsudo <[email protected]> Co-authored-by: cyan <[email protected]> Co-authored-by: David Adegoke <[email protected]>
OmarHatem28
requested changes
Nov 20, 2025
lib/new-ui/new_dashboard.dart
Outdated
Comment on lines
27
to
32
| [ | ||
| getIt.get<NewHomePage>(), | ||
| getIt.get<WalletListPage>(), | ||
| getIt.get<ContactListPage>(), | ||
| getIt.get<CakeFeaturesPage>(), | ||
| Placeholder(), |
Contributor
There was a problem hiding this comment.
Why define the array inside the build function?
This will cause the getters to be called every time this is rebuilt, and since they are registered as factories, then it will re-initialize them.
Extract the array outside of the build function and on its own final variable and just use it here
Comment on lines
30
to
34
| if(FeatureFlag.hasNewUiExtraPages) | ||
| showModalBottomSheet( | ||
| context: context, | ||
| builder: (context) => SendPage(), | ||
| ); else Navigator.of(context).pushNamed(Routes.send); |
Contributor
There was a problem hiding this comment.
reformat the code please, we have a rule for the line length as 100, please set it in your IDE and reformat the code.
Also, please use curly brackets for if/else conditions {}
|
|
||
| if (code == null) return; | ||
| if (code.isEmpty) return; | ||
| final uri = Uri.parse(code); |
Contributor
There was a problem hiding this comment.
Suggested change
| final uri = Uri.parse(code); | |
| final uri = Uri.tryParse(code); | |
| if (uri == null) return; |
Contributor
There was a problem hiding this comment.
reformat as well after setting the line length to 100
Comment on lines
32
to
35
| [ | ||
| AssetsSection(dashboardViewModel: widget.dashboardViewModel,), | ||
| HistorySection(dashboardViewModel: widget.dashboardViewModel,), | ||
| ][_selectedTab], |
Contributor
There was a problem hiding this comment.
same as the earlier comment, why re-initialize them
| children.add(_buildCard(_selectedIndex!, parentWidth)); | ||
| } | ||
|
|
||
| return Observer( |
Contributor
There was a problem hiding this comment.
I don't see an observable variable or a computed getter used here, so why the use of Observer?
also, please reformat the code
Comment on lines
12
to
17
| class NavbarItemData { | ||
| final String iconPath; | ||
| final String text; | ||
|
|
||
| NavbarItemData(this.iconPath, this.text); | ||
| } |
Comment on lines
22
to
28
| final List<NavbarItemData> _items = [ | ||
| NavbarItemData("assets/Home.svg", "Home"), | ||
| NavbarItemData("assets/Wallets.svg", "Wallets"), | ||
| NavbarItemData("assets/Contacts.svg", "Contacts"), | ||
| NavbarItemData("assets/Apps.svg", "Apps"), | ||
| NavbarItemData("assets/Charts.svg", "Charts"), | ||
| ]; |
Contributor
There was a problem hiding this comment.
yup initializing the list like this is good
Contributor
There was a problem hiding this comment.
please reformat this back when you set the line length to 100 so I can review the actual changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Integrate the Home page from the design mockups into the app's current ViewModel. Also fixed positioning and sizing on the new navigation bar. The new UI is accessible by setting the hasNewUi feature flag.
Also merged Lightning wallet support into new-design to simplify working on Lightning-related UI elements.
Pull Request - Checklist