Skip to content

3.x: remove unnecessary parent call in table class #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LordSimal wants to merge 1 commit into from
Closed

3.x: remove unnecessary parent call in table class #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions templates/bake/Model/table.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ class {{ name }}Table extends Table{{ fileBuilder.classBuilder.implements ? ' im
*/
public function initialize(array $config): void
{
parent::initialize($config);

{% if table %}
$this->setTable('{{ table }}');
{% endif %}
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionCategoriesProductsTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ class CategoriesProductsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('categories_products');
$this->setDisplayField(['category_id', 'product_id']);
$this->setPrimaryKey(['category_id', 'product_id']);
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionCategoriesTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ class CategoriesTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('categories');
$this->setDisplayField('name');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionCategoriesTableSigned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ class CategoriesTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('categories');
$this->setDisplayField('name');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionOldProductsTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class OldProductsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('old_products');
$this->setDisplayField('name');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionOldProductsTableSigned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class OldProductsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('old_products');
$this->setDisplayField('name');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionProductVersionsTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class ProductVersionsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('product_versions');
$this->setDisplayField('id');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeAssociationDetectionProductVersionsTableSigned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class ProductVersionsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('product_versions');
$this->setDisplayField('id');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ class ItemsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('todo_items');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableNullableForeignKey.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class TestBakeArticlesTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('bake_articles');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableRules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ class UniqueFieldsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('unique_fields');
$this->setDisplayField('id');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableValidation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class TestBakeArticlesTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('bake_articles');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableWithCounterCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ class TodoTasksTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('todo_tasks');
$this->setDisplayField('title');
$this->setPrimaryKey('uid');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableWithEnum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class TestBakeArticlesTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('bake_articles');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeTableWithPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ class UsersTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('users');
$this->setDisplayField('id');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeUpdateTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ class TodoItemsTable extends Table implements SomeInterface
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('todo_items');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeUpdateTableNoFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ class TodoItemsTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('todo_items');
$this->setDisplayField('title');
$this->setPrimaryKey('id');
Expand Down
2 changes: 0 additions & 2 deletions tests/comparisons/Model/testBakeWithRulesUnique.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ class UsersTable extends Table
*/
public function initialize(array $config): void
{
parent::initialize($config);

$this->setTable('users');
$this->setDisplayField('id');
$this->setPrimaryKey('id');
Expand Down