Allow using __d() in plugin context. #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The base idea is pretty cool, but I don't see any reason why one should use I'd rather always default to |
Member
Author
|
That would simplify it a bit I guess :) |
dereuromark
commented
Sep 29, 2025
| $plugin = $this->plugin; | ||
| if ($plugin) { | ||
| $plugin .= '.'; | ||
| $pluginPath = $plugin; |
Member
Author
There was a problem hiding this comment.
In the process of simplifying I also found a bug: A dot added to plugin is passed along to the templates.
This is now also fixed as a side effect.
# Conflicts: # templates/bake/Template/view.twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible soution to #1038
I wonder if we could make a helper wrapper for translations, to keep the templates more readable?