Add info about HTTP client events. #7769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
reviewed
Nov 18, 2023
en/core-libraries/httpclient.rst
Outdated
| --------------------- | ||
|
|
||
| // Somewhere before calling one of the HTTP client's send methods. | ||
| \Cake\Event\EventManager::instance()->on( |
Contributor
There was a problem hiding this comment.
Aren't events only dispatched on the client object and not on the global event manager?
I just learned instance level events will also appear in the global event manager.
Member
Author
There was a problem hiding this comment.
Hmm.. This makes me think that suggesting $client->getEventManager()->on() would be better.
ADmad
force-pushed
the
http-client-events
branch
from
fff1aa5 to
f701891
Compare
LordSimal
reviewed
Nov 18, 2023
| --------------------- | ||
|
|
||
| // Somewhere before calling one of the HTTP client's methods which makes a request | ||
| $http->getEventManager()->on( |
Contributor
There was a problem hiding this comment.
Suggested change
| $http->getEventManager()->on( | |
| $client->getEventManager()->on( |
Member
Author
There was a problem hiding this comment.
All code examples above use the var $http for the client instance, hence I used the same for consistency.
Member
There was a problem hiding this comment.
The example on 480 uses $client. I can take care of normalizing them all though.
LordSimal
reviewed
Nov 18, 2023
| --------------------- | ||
|
|
||
| // Somewhere before calling one of the HTTP client's methods which makes a request | ||
| $http->getEventManager()->on( |
Contributor
There was a problem hiding this comment.
Suggested change
| $http->getEventManager()->on( | |
| $client->getEventManager()->on( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs cakephp/cakephp#17416