port over enqueue/simple-client
#165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the main repo is https://github.com/php-enqueue/enqueue-dev, the simple-client is just a sub-package of that repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://github.com/php-enqueue/simple-client is not that complicated (and to get rid of 1 more dependency) this is the first step to port over its functionality into the queue plugin.
I have not yet made the tests work, just copied them over and adjusted the namespaces, CS etc.
I am also not sure if we could also drop symfony 5 support here.
If we go this way, this of course requires a new major, therefore I made a new 3.x branch based on current 2.next.