Skip to content

Use empty() instead of negation for result validation #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zigzagdev wants to merge 1 commit into from
Closed

Use empty() instead of negation for result validation #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Job/SendMailJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function execute(Message $message): ?string
Log::error(sprintf('An error has occurred processing message: %s', $e->getMessage()));
}

if (!$result) {
if (empty($result)) {
return Processor::REJECT;
}

Expand Down
12 changes: 6 additions & 6 deletions tests/TestCase/Job/SendMailJobTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function setUp(): void
*
* @return void
*/
public function testExecute()
public function testExecute(): void
{
$job = $this->getMockBuilder(SendMailJob::class)
->onlyMethods(['getTransport'])
Expand All @@ -84,7 +84,7 @@ public function testExecute()
*
* @return void
*/
public function testExecuteTransportName()
public function testExecuteTransportName(): void
{
$job = new SendMailJob();
$message = $this->createMessage('foo', [], $this->message);
Expand All @@ -110,7 +110,7 @@ public function testExecuteTransportName()
*
* @return void
*/
public function testExecuteWithAttachments()
public function testExecuteWithAttachments(): void
{
$emailMessage = clone $this->message;
$emailMessage->addAttachments(['test.txt' => ROOT . 'files' . DS . 'test.txt']);
Expand All @@ -124,7 +124,7 @@ public function testExecuteWithAttachments()
*
* @return void
*/
public function testExecuteInvalidTransport()
public function testExecuteInvalidTransport(): void
{
$message = $this->createMessage('WrongTransport', [], $this->message);
$actual = $this->job->execute($message);
Expand All @@ -136,14 +136,14 @@ public function testExecuteInvalidTransport()
*
* @return void
*/
public function testExecuteUnserializableMessage()
public function testExecuteUnserializableMessage(): void
{
$message = $this->createMessage(DebugTransport::class, [], 'unserializable');
$actual = $this->job->execute($message);
$this->assertSame(Processor::REJECT, $actual);
}

public function testExecuteNoAbstractTransport()
public function testExecuteNoAbstractTransport(): void
{
$message = $this->createMessage(Mailer::class, [], $this->message);
$actual = $this->job->execute($message);
Expand Down
Loading