Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: run pre-commit on all files #2696

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Chore: run pre-commit on all files #2696

merged 1 commit into from
Feb 20, 2025

Conversation

angela-tran
Copy link
Member

We're not sure what changed to cause the prettier pre-commit hook to fail on styles.css and variables.css. It keeps getting re-run on our PRs like #2691 and #2689 and even on merges into main, so let's just apply the re-formatting so it stops re-running.

Ran pre-commit run --all-files:

not sure what changed that causes the prettier pre-commit hook to
start failing on this. go ahead and apply it so it stops getting in
our way in PRs.
@angela-tran angela-tran requested a review from a team as a code owner February 20, 2025 00:47
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Feb 20, 2025
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg thank you 😭

@angela-tran angela-tran merged commit af24360 into main Feb 20, 2025
12 checks passed
@angela-tran angela-tran deleted the chore/pre-commit-css branch February 20, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants