-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: context module into a package #2697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
b3df575
to
007d906
Compare
thekaveman
reviewed
Feb 20, 2025
3 tasks
thekaveman
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great 👍
I think this can close #2682 since we decided to ignore frozen data classes for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
back-end
Django views, sessions, middleware, models, migrations etc.
deployment-dev
[auto] Changes that will trigger a deploy if merged to dev
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2682
This PR addresses:
context
folder that has a package initialization file (__init__.py
) and moving the agency-specific context code into anagency
module within the package_context
from the module-level variables.value
when constructing the dictionary