Feat: prevent agency from being saved if it doesn't have copy for index #2713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2705, I realized that it would help prevent errors if
TransitAgency.clean
checks that the agency has all the copy it will need. That is, theclean
method should try to call each@property
method for getting the context dictionary for whatever page and make sure calling that method doesn't raise an error.This is similar to how
EnrollmentFlow.clean
checks that the flow is able to get itsin_person_eligibility_context
if it is an in-person flow.Basically if somehow we've forgotten to add copy for some slug, or if we accidentally remove copy from one of the mappings, then upon saving, we'll realize it.