Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: ensure core_context.agency_index contains all AgencySlugs #2714

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Test: ensure core_context.agency_index contains all AgencySlugs #2714

merged 1 commit into from
Feb 28, 2025

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Feb 28, 2025 •
edited
Loading

This will protect us from forgetting to add Agency Index copy.

Other PRs (like #2705) can add their own tests.

@angela-tran angela-tran added this to the Simplify templates milestone Feb 28, 2025
@angela-tran angela-tran self-assigned this Feb 28, 2025
@angela-tran angela-tran requested a review from a team as a code owner February 28, 2025 03:39
@github-actions github-actions bot added the tests Related to automated testing (unit, UI, integration, etc.) label Feb 28, 2025
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@angela-tran angela-tran mentioned this pull request Feb 28, 2025
Open
thekaveman
thekaveman approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the parameter sends all the possible values of AgencySlug into the test and then just verifies they are in the agency_index dict?

I like it!

@angela-tran
Copy link
Member Author

So the parameter sends all the possible values of AgencySlug into the test and then just verifies they are in the agency_index dict?

I like it!

Yep! Thanks

@angela-tran angela-tran merged commit 0b105c2 into main Feb 28, 2025
16 checks passed
@angela-tran angela-tran deleted the feat/test-agency-index-copy branch February 28, 2025 17:13
@lalver1 lalver1 mentioned this pull request Mar 10, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Simplify templates
Development

Successfully merging this pull request may close these issues.
2 participants
@angela-tran @thekaveman