Skip to content

Conversation

@SafaSafari
Copy link

Description of Changes

Fixes #283.

Major Changes Implemented:

  • fix module function
  • fix path class

Pre-Merge Tasks

  • Formatted all modified files w/ python-black
  • Sorted imports for modified files w/ isort
  • Ran flake8 on repo, and fixed any new problems w/ modified files
  • Ran pytest test cases
  • Added brief summary of updates to CHANGELOG (under [Unreleased])

@SafaSafari SafaSafari changed the title fix for python >= 12 fix for python >= 3.12 Aug 9, 2024
@scmanjarrez
Copy link

scmanjarrez commented Oct 6, 2024

Hey, I found your changes, do you mind updating the "import pkg_resources" too? This way we have all the patches in the same repository. The function files() apparently is the replacement. I think we will need to use this zodburi version too https://github.com/Pylons/zodburi/tree/modernize-python-versions.

Edit: I made a commit on top of your changes scmanjarrez@236ec07

@grav3m1nd-byte
Copy link

I'd be interested to see a permanent fix for this if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'FileFinder' object has no attribute 'find_module'

3 participants