Fix OpenVPN import issue #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the command `htb lab import` would fail. This is because it was writing an empty file, as the write() would be buffered and not flush to file before the `nmcli` import was called. This change explicitly calls flush() to commit the changes to the file, meaning the contents is written to the file. Fixes: calebstewart#6 Signed-off-by: Dave Walker (Daviey) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the command
htb lab importwould fail. This is because itwas writing an empty file, as the write() would be buffered and not
flush to file before the
nmcliimport was called.This change explicitly calls flush() to commit the changes to the file,
meaning the contents is written to the file.
Fixes: #6
Signed-off-by: Dave Walker (Daviey) [email protected]