Fixes #69: add missing render_runtime to edit_decisions fixture in test_08#126
Open
Diwakar-odds wants to merge 1 commit into
Open
Fixes #69: add missing render_runtime to edit_decisions fixture in test_08#126Diwakar-odds wants to merge 1 commit into
Diwakar-odds wants to merge 1 commit into
Conversation
rajpratham1
approved these changes
Jun 22, 2026
rajpratham1
left a comment
rajpratham1
left a comment
There was a problem hiding this comment.
This is a small but important test fix. Adding the missing render_runtime field keeps the test fixture aligned with the current schema and ensures the end-to-end test reflects the expected production input. Since the change only updates test data and doesn't modify application logic, the risk is minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #69. The test_08_end_to_end.py automated test was crashing because the mock edit_decisions test fixture was missing the render_runtime field, which is marked as strictly required in schemas/artifacts/edit_decisions.schema.json.
I added "render_runtime": "remotion" to the mock dictionary to align it with the proposal_packet output earlier in the test, which allows the test suite to pass schema validation successfully.