Skip to content

feat: add size prop to List.Icon component #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add size prop to List.Icon component #4400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/List/ListIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ export type Props = {
* @optional
*/
theme?: ThemeProp;
/**
* Size of the icon.
*/
size?: number;
};

const ICON_SIZE = 24;
Expand All @@ -34,7 +38,7 @@ const ICON_SIZE = 24;
* const MyComponent = () => (
* <>
* <List.Icon color={MD3Colors.tertiary70} icon="folder" />
* <List.Icon color={MD3Colors.tertiary70} icon="equal" />
* <List.Icon color={MD3Colors.tertiary70} size={20} icon="equal" />
* <List.Icon color={MD3Colors.tertiary70} icon="calendar" />
* </>
* );
Expand All @@ -47,15 +51,17 @@ const ListIcon = ({
color: iconColor,
style,
theme: themeOverrides,
size,
}: Props) => {
const theme = useInternalTheme(themeOverrides);
const iconSize = size ? size : ICON_SIZE;

return (
<View
style={[theme.isV3 ? styles.itemV3 : styles.item, style]}
pointerEvents="box-none"
>
<Icon source={icon} size={ICON_SIZE} color={iconColor} theme={theme} />
<Icon source={icon} size={iconSize} color={iconColor} theme={theme} />
</View>
);
};
Expand Down
27 changes: 27 additions & 0 deletions src/components/__tests__/ListItem.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,30 @@ it('renders list item with custom content style', () => {

expect(getByTestId('list-item-content')).toHaveStyle(styles.content);
});

it('renders list item with custom icon size with left and right items', () => {
const tree = render(
<ListItem
title="First Item"
description="Item description"
testID={testID}
left={() => <Text>GG</Text>}
right={() => <ListIcon size={10} icon="folder" />}
/>
).toJSON();

expect(tree).toMatchSnapshot();
});

it('renders list item on left with a icon that has a custom size', () => {
const tree = render(
<ListItem
title="First Item"
description="Item description"
testID={testID}
left={() => <ListIcon size={10} icon="folder" />}
/>
).toJSON();

expect(tree).toMatchSnapshot();
});
Loading