Skip to content

feat: Complete FAB Menu behavior and web adaptation - #5170

Open
alpharius-ck wants to merge 11 commits into
mainfrom
refactor-fab
Open

alpharius-ck wants to merge 11 commits into
mainfrom
refactor-fab

Conversation

@alpharius-ck

@alpharius-ck alpharius-ck commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

FAB.Menu did not follow the Material 3 spec or the other v6 components in a few ways. On web it did not tell assistive technology whether it was open. Collapsed items stayed in the tab order and the accessibility tree. Items had no hover, focus or press feedback, and a menu taller than the screen could not scroll.

This PR fixes those. Dismissal (Escape, Android back, outside press, screen reader escape) and focus handling (focus on open, restore on close) are intentionally left out and belong to the overlay work in #5127. A follow-up will wire FAB.Menu into that portal stack. Until then, the menu closes only through its trigger and items, as on main.

Builds on #5110 (variant rename). It also covers the aria-expanded change from #5151, so one of the two should be dropped when they land.

Related issue

https://app.notion.com/p/callstack/Complete-FAB-Menu-behavior-and-web-adaptation-3ac5d027c0f8806ba4f8f5a8cc061eac?v=3285d027c0f880a68ccb000c1ce3c56e&source=copy_link

Screenshots / Videos

fab-ios fab-general fab-android fab-web

Test plan

Use the example app: FAB → menu (yarn example web, yarn example ios, yarn example android).

Web

  1. In dev tools, the closed trigger has aria-expanded="false" and aria-haspopup="menu". After opening, it has aria-expanded="true", and the items container has role="menu".
  2. With the menu closed, Tab does not stop on any item. With it open, Tab reaches the items.
  3. With focus on an item, ArrowUp/ArrowDown, Home and End move focus through the items and then the close button, and wrap around. Arrow keys do nothing when focus is outside the menu.
  4. Hover, keyboard-focus and press an item. The state layer and elevation change. The focus ring appears for keyboard focus only, not mouse clicks. The state resets after the menu closes.
  5. Shrink the window height so the items don't fit. They scroll, the close button stays reachable, and the scroll position returns to the top each time the menu opens.

iOS / Android

  1. On a short screen or in landscape (Android: adb shell wm size 1080x1000), the items scroll to the last one. Reopening starts at the top.
  2. With VoiceOver or TalkBack on, collapsed items are not announced. Expanded items are announced, and the trigger is announced as expanded or collapsed.
  3. Press and hold an item (touch), or hover it on iPad with a pointer. The state layer shows and clears.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Found potential problems with the pull request:

  • The description is too long. Please keep it under 1000 characters.

alpharius-ck and others added 4 commits November 5, 2026 17:01
# Conflicts:
#	src/components/FAB/Shell.tsx
The previous merge of main kept the old versions of most files that
changed on main. Bring the tree to main plus the FAB menu changes so the
PR only shows the FAB files.

Type the FAB refs with ComponentRef<typeof View> and
ComponentRef<typeof ScrollView>, as main does, since View and ScrollView
are no longer instance types on React Native 0.88.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Doberjohn

Copy link
Copy Markdown
Collaborator

Thanks for the videos @likevy, they look good. After I updated the branch, Typecheck and Build package fail: React Native 0.88 (from #5167) now types onKeyDown and onKeyUp on View and Pressable with its own key event, so the React DOM KeyboardEvent in useSpaceKeyPress no longer fits. Replacing it with only what the handlers read fixes it and passes the legacy types check too:

type KeyboardEvent = {
  nativeEvent: { key: string; repeat?: boolean | undefined };
  preventDefault: () => void;
};

Could you push that? Then I'll do the last checks and merge.

@alpharius-ck

Copy link
Copy Markdown
Collaborator Author

Thanks for the videos @likevy, they look good. After I updated the branch, Typecheck and Build package fail: React Native 0.88 (from #5167) now types onKeyDown and onKeyUp on View and Pressable with its own key event, so the React DOM KeyboardEvent in useSpaceKeyPress no longer fits. Replacing it with only what the handlers read fixes it and passes the legacy types check too:

type KeyboardEvent = {
  nativeEvent: { key: string; repeat?: boolean | undefined };
  preventDefault: () => void;
};

Could you push that? Then I'll do the last checks and merge.

sure - would do asap

@alpharius-ck

Copy link
Copy Markdown
Collaborator Author

@Doberjohn branch is working correctly with RN 0.88

alpharius-ck and others added 3 commits November 16, 2026 09:37
Resolve FAB.Menu against the shared `useFocusRing` from main, and make the
menu a proper overlay: Escape, Android back and the iOS escape gesture
dismiss it, focus moves to the first item on open and returns to the
trigger on close.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@jacekAtCK jacekAtCK left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the rebase on main and the keyboard issues on web. Details are inline.

// first mount doesn't animate unexpectedly.
const scaleX = useSharedValue(expanded ? 1 : 0);
const alpha = useSharedValue(expanded ? 1 : 0);
const { scale } = theme.animation;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5235 removed theme.animation.scale from main, so after the rebase this line and lines 308 and 510 should fail typecheck. Could you replace the * scale parts with useReduceMotion(), as other components on main do?

>
{overlay}
<TouchableRipple
ref={buttonRef}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main now passes a web-only touchableRef to this same TouchableRipple to blur and restore focus when the FAB hides, so it conflicts with buttonRef here. Could you merge both refs into one during the rebase?

onHoverOut={() => setHovered(false)}
onPressIn={() => setPressed(true)}
onPressOut={() => setPressed(false)}
role={Platform.OS === 'web' ? 'menuitem' : 'button'}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space does nothing on a focused item on web (Enter works), because RNW presses on Space only for role="button". Could you add useSpaceKeyPress to the item, as Checkbox does?

// `aria-hidden` and `pointerEvents` don't take collapsed items
// out of the tab order.
focusable={expanded}
tabIndex={expanded ? 0 : -1}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On web every item is a Tab stop, Tab leaves the menu while it stays open, and ArrowUp from the first item or End jumps to the close button, which is outside role="menu". Could we use a roving tabindex with aria-labelledby on the menu, or drop the menu and menuitem roles and use buttons in a labelled group?

@@ -552,12 +672,145 @@ const Menu = ({

const effectiveExpanded = triggerVisible && expanded;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the FAB hides while the menu is open, onDismiss is not called, so parent keeps expanded=true. When I turned "Show FAB" off and on, the menu opened again by itself and focus jumped to "Send", so could we call onDismiss when the trigger hides?

expanded: boolean;
/**
* Called when the user taps the close button or taps an item.
* Called when the menu should close: the user taps the close button, an

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing closes the menu on an outside press (I clicked outside on web and it stayed open), and main's migration guide says on purpose that it does not. Could we drop "or outside the menu" here and "Pressing outside the menu" on line 626?


// The screen reader is sent to an element, which the test can only tell
// apart by the `testID` it was given.
const focusedTestID = () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we drop the eslint-disable and the cast here? toHaveBeenCalledWith(expect.objectContaining({ props: expect.objectContaining({ testID: 'item-0' }) }), 'focus') should check the same thing.

pressed: stateOpacity.pressed,
} as const satisfies Record<Interaction, number>;

export const webNoHoverTint: ViewStyle = { backgroundColor: 'transparent' };

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is webNoHoverTint a token or more like a style? Maybe it should be in Menu itself?

@Doberjohn Doberjohn added this to the 6.0.0 milestone Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants