Skip to content

fix(android): android gradle plugin 8 compatibility #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

mikehardy
Copy link
Contributor

Summary:

This is the minimum required change for this module to work on react-native 0.73 which includes android gradle plugin 8

This module does not just require namespace it also requires the buildConfig feature turned on, as discovered in actual use in a work app as I tested AGP8+ to fix up modules I maintain and modules I depend on

It is similar to changes I needed to do as react-native-firebase maintainer --> invertase/react-native-firebase@b52d0ce

Test Plan

With apologies, you have to alter an app that integrates this module to use android gradle plugin 8, it's difficult to do that in repos I'm proposing these changes in because bumping to android gradle plugin 8 requries a large amount of transitive dependency changes in CI

I have integrated this in an app and tested it, and done similar work as maintainer of react-native-firebase, react-native-netinfo and react-native-device-info, and I'm now pushing these out to the repos

Cheers

Copy link
Member

@BartoszKlonowski BartoszKlonowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @mikehardy 👍
I've allowed myself to add a suggestion regarding the specific v7.3 instead of just v7, to make sure we do not add the namespace for versions in between.
Once it's CI-checked, I'll merge your PR.

@BartoszKlonowski BartoszKlonowski merged commit f569bfe into callstack:main Dec 1, 2023
@mikehardy mikehardy deleted the patch-1 branch December 1, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants